Leaping legs mutation will now delete the spell when lost (now it really works) #60719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
NetSysFire
added
Mutations / Traits / Professions/ Hobbies
|
A different issue and out of scope for this PR, but there should really be some sort of flag that distinguishes abilities (like pounce and leap) from actual spells (magiclysm) so you do not get all these achievements and weird wordings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Some spells are left with the character, when mutation, that gives them, is gone
Fixes #53860
Describe the solution
Adding
MUST_HAVE_CLASS_TO_LEARNflag and"spell_class": "MUTATION_THAT_GIVES_THE_SPELL",combination fix thisDescribe alternatives you've considered
Maybe rename
spell_classandMUST_HAVE_CLASS_TO_LEARNfileds in the futureTesting
Yep, now it works
Screenshots
Additional context
ugh now i need to resolve a stupid merge conflicts in the future :(