Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMore death functionality. #6104
Conversation
Soyweiser
added some commits
Feb 14, 2014
Soyweiser
added some commits
Feb 14, 2014
This comment has been minimized.
This comment has been minimized.
|
Fixed the build failure. |
KA101
self-assigned this
Feb 15, 2014
KA101
reviewed
Feb 15, 2014
| @@ -3685,7 +3685,7 @@ | |||
| "luminance":0, | |||
| "hp":250, | |||
| "special_freq":0, | |||
| "death_function":"AMIGARA", | |||
| "death_function":["AMIGARA", "NORMAL"], | |||
This comment has been minimized.
This comment has been minimized.
KA101
Feb 15, 2014
Contributor
Amigaras don't leave corpses currently; I'm kinda inclined to leave 'em that way but open to changing it.
This comment has been minimized.
This comment has been minimized.
Soyweiser
Feb 15, 2014
Author
Contributor
That is odd, as the old AMIGARA death function did call normal. That is why I gave the amigara monsters the normal death function as well.
KA101
removed their assignment
Feb 15, 2014
Soyweiser
added some commits
Feb 15, 2014
kevingranade
merged commit a4a4ec0
into
CleverRaven:master
Feb 17, 2014
1 check passed
default
Details
Soyweiser
deleted the
Soyweiser:more_death
branch
Feb 17, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Soyweiser commentedFeb 14, 2014
Death function now accepts stuff like:
"death_function":["NORMAL", "ZOMBIE"]
The dies mtype variable is now a vector of pointers to death functions. All get called on death.
A zombie needs both the normal and zombie tag. Added.
Checked the dinomod. But no changes where needed.
Added a bile blood tag, and fixed the acid blood tag. Both are different effects from boomering and acid exploding. Corpses can now be acid. So when smashed they leave acid pools.
Added ZOMBIE and NORMAL to the spitter. So the spitter leaves a corpse again. (But it dissolves rapidly. But explodes into a 3x3 acid pool if smashed).