Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes second part of #6145 #6147
Conversation
Rivet-the-Zombie
added a commit
that referenced
this pull request
Feb 18, 2014
Rivet-the-Zombie
merged commit 500d382
into
CleverRaven:master
Feb 18, 2014
1 check passed
default
This has been rescheduled for testing as the 'master' branch has been updated.
BevapDin
deleted the
BevapDin:fridges
branch
Feb 18, 2014
origamiwolf
added a commit
to origamiwolf/DinoCataclysm
that referenced
this pull request
Feb 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BevapDin commentedFeb 17, 2014
Fixes second part of #6145
Food in containers rots, because
item::fridgeis only set for the container, not for the content, fixed herby.Item not getting cool is caused by the item_counter, which is unsigned and gets decremented by 10 in the fridge. The code that handles cool down process_active_item decrements it further and than checks it against 0. In 9 of 10 cases the decrementing leads to an overflow and item_counter is now very big (and not even near 0). And the whole cycle starts again.