Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed JSON to reflect empty air #61875

Merged
merged 1 commit into from Oct 24, 2022
Merged

Conversation

azalahli
Copy link
Contributor

Summary

BugFixes "space in JSON should be air, not ground terrain for roof"

Purpose of change

Fixes #60470

Describe the solution

The roof draws from a palette afs_habitat_structure, which defines " " as regional groundcover. I added " ": "t_open_air" to fix it, as editing the palette would have secondary effects on other mapgen

Describe alternatives you've considered

Testing

Compiled on windows, enabled debug mode, and spawned a Stratoscomm Relay Station, then teleported myself onto the roof

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 23, 2022
@dseguin dseguin merged commit a27272e into CleverRaven:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stratoscomm relay station has an abnormal roof
3 participants