Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: connect extension cables between vehicles and appliances #62475

Merged
merged 1 commit into from Nov 29, 2022

Conversation

dseguin
Copy link
Member

@dseguin dseguin commented Nov 29, 2022

Summary

None

Purpose of change

Describe the solution

Incorporate only the fix portion of #60851.

Describe alternatives you've considered

The extra power conversion stuff from that PR can be implemented for 0.H

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 29, 2022
@I-am-Erk I-am-Erk merged commit 8f1cbbf into CleverRaven:master Nov 29, 2022
@dseguin dseguin deleted the app_veh_power_simple branch November 29, 2022 23:14
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 30, 2022
@Raikiri
Copy link

Raikiri commented Dec 13, 2022

excuse me, I have tried connecting two vehicles with an extension cord, it gave me the message "You link up the electric systems of and ", but I don't see the systems as actually linked and I also can't now remove my cable either? It has just straight up disappeared. I tried the same thing with another cable and the same thing happened.

@dseguin
Copy link
Member Author

dseguin commented Dec 14, 2022

Are you sure you're running an up-to-date build? I just tested it with two cars and two welding carts and it works as expected. I even tried it across overmap boundaries just to check and it's balancing power properly.

Can you create a new issue and attach your save?

@Raikiri
Copy link

Raikiri commented Dec 14, 2022

Maybe i'm just using it wrong? I go "a"ctivate->extension cord, select a vehicle with the engine turned on, then I hit "a"ctivate again, the extension cord is now highlighted yellow and says that one of its ends is attached, then I select the other vehicle (which is one tile apart), it says that their electric systems are now connected and the cable disappears from my inventory.

But I don't see any indication of the battery in one vehicle being charged by the running engine (with an alternator) in the other one. I also don't see a way to remove the cable. How am I expected to detach the cable?

I am running experimental from about 5 days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension cord cannot be plugged into vehicle
3 participants