-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented category fallback for tile rendering #6349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to rearrange initialization to make things work right.
If this doesn't work I may have to bring back the rotation cache.
First of two hunches I can trying to get the offsets working right without having to use a rotation cache.
For instance, "unknown_monster" will serve as fallback for monsters without sprites, and "unknown_monster_MAMMAL" will serve as fallback for species MAMMAL without sprite. Similarly. "unknown_item" will serve as fallback for items without sprite, and "item_unknown_CONTAINER" will serve as fallback for containers with no sprite.
Wow, yes yes yes! |
That SDL2 PR is likely to be the first one out of the pipe once 0.A lands and we have experimentals back. So yeah, this'll be good. |
kevingranade
changed the title
Implemented category fallback for tile rendering [depends SDL2]
Implemented category fallback for tile rendering
Sep 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, "unknown_monster" will serve as fallback for monsters without sprites, and "unknown_monster_MAMMAL" will serve as fallback for species MAMMAL without sprite. Similarly. "unknown_item" will serve as fallback for items without sprite, and "item_unknown_CONTAINER" will serve as fallback for containers with no sprite.
This PR depends on the SDL2 PR to land first.
Wiki: http://www.wiki.cataclysmdda.com/index.php?title=Tileset_Support#Defining_a_sprite_for_a_group_of_objects