Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upA fix for SDL for mingw windows compiling. #6410
Conversation
This comment has been minimized.
This comment has been minimized.
|
Compiles/runs fine on linux curses and tiles, just need someone to confirm on windows. |
This comment has been minimized.
This comment has been minimized.
|
It doesn't work under windows (segfault when trying to draw tiles). |
This comment has been minimized.
This comment has been minimized.
|
Unrelated to this fix, that issue occurred before hand. I tried sorting that out, but it doesn't crash when in GDB. |
This comment has been minimized.
This comment has been minimized.
|
Ah, compiling... "I'm dead tired", need some sleep. |
This comment has been minimized.
This comment has been minimized.
|
I'm pulling, this LOOKS good, and evidently Wishbrainger was able to compile, but not run, which is same as previous. |
kevingranade
merged commit 042f23d
into
CleverRaven:master
Mar 9, 2014
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Old news, but for the record, the problem with crashes was solved with those SDL2 specific "zlib1.dll", "freetype6.dll" and "libpng16-16.dll" files. They should be included in the future. |
This comment has been minimized.
This comment has been minimized.
|
Confirmed. News to me.. Crash on load and crash on launch fixed by including "libpng16-16.dll" and "zlib1.dll" from sdl_image. libfreetype-6.dll has no effect on the crashing for me. Here is a zip of the relevant dlls for inclusion. http://www.mediafire.com/download/57c2kek1amnknmj/catatiles_win32_dlls.zip |
Chase-san
deleted the
Chase-san:SDL2Fix
branch
Mar 11, 2014
This comment has been minimized.
This comment has been minimized.
|
Agreed, I just removed "libfreetype-6.dll" and it still works. No noticeable render slowdown even when fully zoomed out. |
Chase-san commentedMar 3, 2014
You shouldn't have to put SDL/SDL2 in the root include directory. If your machine is setup like that, then your machine is setup wrong. At least for mingw. MSVC puts it in the base directory by default, but they don't have to build with the Makefile.
This also fixes a few compile time bugs I stumbled across.