Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A fix for SDL for mingw windows compiling. #6410

Merged
merged 1 commit into from Mar 9, 2014

Conversation

Projects
None yet
3 participants
@Chase-san
Copy link
Contributor

commented Mar 3, 2014

You shouldn't have to put SDL/SDL2 in the root include directory. If your machine is setup like that, then your machine is setup wrong. At least for mingw. MSVC puts it in the base directory by default, but they don't have to build with the Makefile.

This also fixes a few compile time bugs I stumbled across.

A slight fix for SDL2 for windows compiling.
You shouldn't have to put SDL2 in the root include directory. If your
machine is setup like that, then your machine is setup wrong.
@kevingranade

This comment has been minimized.

Copy link
Member

commented Mar 4, 2014

Compiles/runs fine on linux curses and tiles, just need someone to confirm on windows.

@Wishbringer

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2014

It doesn't work under windows (segfault when trying to draw tiles).

@Chase-san

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2014

Unrelated to this fix, that issue occurred before hand. I tried sorting that out, but it doesn't crash when in GDB.

@Wishbringer

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2014

Ah, compiling... "I'm dead tired", need some sleep.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Mar 9, 2014

I'm pulling, this LOOKS good, and evidently Wishbrainger was able to compile, but not run, which is same as previous.

@kevingranade kevingranade merged commit 042f23d into CleverRaven:master Mar 9, 2014

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.
@Wishbringer

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2014

Old news, but for the record, the problem with crashes was solved with those SDL2 specific "zlib1.dll", "freetype6.dll" and "libpng16-16.dll" files. They should be included in the future.

@Chase-san

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2014

Confirmed. News to me..

Crash on load and crash on launch fixed by including "libpng16-16.dll" and "zlib1.dll" from sdl_image. libfreetype-6.dll has no effect on the crashing for me.

Here is a zip of the relevant dlls for inclusion. http://www.mediafire.com/download/57c2kek1amnknmj/catatiles_win32_dlls.zip

@Chase-san Chase-san deleted the Chase-san:SDL2Fix branch Mar 11, 2014

@Wishbringer

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2014

Agreed, I just removed "libfreetype-6.dll" and it still works. No noticeable render slowdown even when fully zoomed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.