New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed myself from codeowners and maintainers of No Hope mod #64618
Conversation
|
No hope for No Hope? |
|
Please sleep one night over it. I know this (#58380 (comment) and #62760 (comment)) is probably stemming from some discord drama which I have not seen, but rest assured that your contributions are still appreciated and I would be sad to see you leave. |
|
SysFire is absolutely right, the community definitely appreciates every single work you do, and that alone is worth the effort. |
|
I hope it's not getting merged |
|
For those unaware: #64586 (Closed PR that led to this whole debacle). Thank you for your contributions NP, sad to see you go. |
|
As much as I hate to potentially bring up drama, I do partially understand NP's reason and a similar thing happened in e.g #54439. Closing PRs with "Nope" or similarly nondescriptive and unhelpful comments (including nothing) has got to stop, especially when the reactions to the PR are overwhelmingly positive. |
|
The bloating of the options menu (whether you agree with it or not) was particularly exacerbated in this case though, and NP was previously aware of this being an issue (#62583 (comment)). I can't find it on GH, maybe it was on discord, but I distinctly remember Kevin firmly telling him: No, do not make it an option. It takes up an entire scrollable settings page to display the categories, so I personally can see why this is a problem... and this is kevin's position which has been widely known. Attempting to PR that was never going to end well, although it could have been handled with more tact. |
No, it wasn't on GH and no, it wasn't on Discord, nor anywhere else. We never discussed this particular feature with Kevin and thus he never explicitly stated his opinion on it and form it should be implemented in. |
|
This looks bad. What is the reason for rejecting the "in game options Item category spawn rate"? It was widely appraised by the players; and I personally was really looking forward to it. Food spawn is over the roof, and setting item spawn to 0,25 or so makes ammo and guns a bit too scarce. The reason of UI bloat is absolute bullshit. It would be indeed true if the 20 lines of item categories were to be displayed at all times, but they are nested inside a single line and only shown if opened. Very tidy. The reddit thread discussing this has been closed due to "brigading". No clear feedback or reason given for rejecting an objectively excellent QoL improvement. NPs comment on "I can't stand the tyranny no more." Dark days ahead indeed. |
|
@OneThousandResets In the past, for similar requests, "UI bloat" was indeed given as a reason. However I agree with the previous posters that closing a PR with "Nope" is definitely not conducive to good communication/spirits |
Summary
None
Purpose of change
Describe the solution
Describe alternatives you've considered
Testing
Additional context