Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed myself from codeowners and maintainers of No Hope mod #64618

Merged
merged 1 commit into from Mar 28, 2023

Conversation

Night-Pryanik
Copy link
Member

Summary

None

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tooling Tooling that is not part of the main game but is part of the repo. Mods Issues related to mods or modding Mods: No Hope Relating to the mod No Hope json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 27, 2023
@Kamejeir
Copy link
Contributor

No hope for No Hope?

@NetSysFire
Copy link
Member

Please sleep one night over it. I know this (#58380 (comment) and #62760 (comment)) is probably stemming from some discord drama which I have not seen, but rest assured that your contributions are still appreciated and I would be sad to see you leave.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 27, 2023
@Nebnis
Copy link
Contributor

Nebnis commented Mar 28, 2023

SysFire is absolutely right, the community definitely appreciates every single work you do, and that alone is worth the effort.

@Raikiri
Copy link

Raikiri commented Mar 28, 2023

I hope it's not getting merged

@kevingranade kevingranade merged commit 5788e31 into CleverRaven:master Mar 28, 2023
25 checks passed
@Night-Pryanik Night-Pryanik deleted the no-np-anymore branch March 28, 2023 02:46
@Termineitor244
Copy link
Contributor

For those unaware:

https://www.reddit.com/r/cataclysmdda/comments/123w2oh/the_end/?utm_source=share&utm_medium=android_app&utm_name=androidcss&utm_term=1&utm_content=share_button

#64586 (Closed PR that led to this whole debacle).

Thank you for your contributions NP, sad to see you go.

@NetSysFire
Copy link
Member

As much as I hate to potentially bring up drama, I do partially understand NP's reason and a similar thing happened in e.g #54439. Closing PRs with "Nope" or similarly nondescriptive and unhelpful comments (including nothing) has got to stop, especially when the reactions to the PR are overwhelmingly positive.

@RenechCDDA
Copy link
Contributor

The bloating of the options menu (whether you agree with it or not) was particularly exacerbated in this case though, and NP was previously aware of this being an issue (#62583 (comment)). I can't find it on GH, maybe it was on discord, but I distinctly remember Kevin firmly telling him: No, do not make it an option. It takes up an entire scrollable settings page to display the categories, so I personally can see why this is a problem... and this is kevin's position which has been widely known.

Attempting to PR that was never going to end well, although it could have been handled with more tact.

@Night-Pryanik
Copy link
Member Author

Night-Pryanik commented Mar 28, 2023

I can't find it on GH, maybe it was on discord, but I distinctly remember Kevin firmly telling him: No, do not make it an option.

No, it wasn't on GH and no, it wasn't on Discord, nor anywhere else. We never discussed this particular feature with Kevin and thus he never explicitly stated his opinion on it and form it should be implemented in.

@OneThousandResets
Copy link

This looks bad.

What is the reason for rejecting the "in game options Item category spawn rate"? It was widely appraised by the players; and I personally was really looking forward to it. Food spawn is over the roof, and setting item spawn to 0,25 or so makes ammo and guns a bit too scarce.

The reason of UI bloat is absolute bullshit. It would be indeed true if the 20 lines of item categories were to be displayed at all times, but they are nested inside a single line and only shown if opened. Very tidy.

The reddit thread discussing this has been closed due to "brigading". No clear feedback or reason given for rejecting an objectively excellent QoL improvement. NPs comment on "I can't stand the tyranny no more."

Dark days ahead indeed.

@Zireael07
Copy link
Contributor

@OneThousandResets In the past, for similar requests, "UI bloat" was indeed given as a reason. However I agree with the previous posters that closing a PR with "Nope" is definitely not conducive to good communication/spirits

@CleverRaven CleverRaven locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: No Hope Relating to the mod No Hope Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants