Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRefillable vehicle parts failure grammar improvement #6639
Conversation
Soyweiser
added some commits
Mar 14, 2014
This comment has been minimized.
This comment has been minimized.
|
Why only one part when in same cursor position can be many of them? |
This comment has been minimized.
This comment has been minimized.
|
Because I thought parts looked ugly (but I'm not a native speaker). And it seems more acceptable that it says part when there are indeed parts (as the multitude of the parts is not the important information that the message tries to convey). Then it saying parts when there is only one part. I wanted to use the term "fuel tank" but this error message can also occur with batteries and water tanks * iirc. So ideally it would be split out for multiple part types. But that would create more maintenance later when even more types of fuel tanks are added. *Edit: and atomic power probably. |
This comment has been minimized.
This comment has been minimized.
|
Ok. May be you're right. |
This comment has been minimized.
This comment has been minimized.
|
Well not sure. English language is not my strong suit. Non native etc. |
This comment has been minimized.
This comment has been minimized.
|
I'm with @Soyweiser on 'part' versus 'parts'. It looks better in the singular. |
Soyweiser commentedMar 14, 2014
http://smf.cataclysmdda.com/index.php?topic=5587.0
Changed the wording. Also changed 'parts' into 'part' as that looked more like a normal English sentence.