Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refillable vehicle parts failure grammar improvement #6639

Merged
merged 2 commits into from Mar 14, 2014

Conversation

Projects
None yet
3 participants
@Soyweiser
Copy link
Contributor

commented Mar 14, 2014

http://smf.cataclysmdda.com/index.php?topic=5587.0

Changed the wording. Also changed 'parts' into 'part' as that looked more like a normal English sentence.

Soyweiser added some commits Mar 14, 2014

@VlasovVitaly

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2014

Why only one part when in same cursor position can be many of them?

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2014

Because I thought parts looked ugly (but I'm not a native speaker). And it seems more acceptable that it says part when there are indeed parts (as the multitude of the parts is not the important information that the message tries to convey). Then it saying parts when there is only one part.

I wanted to use the term "fuel tank" but this error message can also occur with batteries and water tanks * iirc. So ideally it would be split out for multiple part types. But that would create more maintenance later when even more types of fuel tanks are added.

*Edit: and atomic power probably.

@VlasovVitaly

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2014

Ok. May be you're right.

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2014

Well not sure. English language is not my strong suit. Non native etc.

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Mar 14, 2014

I'm with @Soyweiser on 'part' versus 'parts'. It looks better in the singular.

Rivet-the-Zombie added a commit that referenced this pull request Mar 14, 2014

Merge pull request #6639 from Soyweiser/proper_fuel
Refillable vehicle parts failure grammar improvement

@Rivet-the-Zombie Rivet-the-Zombie merged commit de33abf into CleverRaven:master Mar 14, 2014

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.

@Soyweiser Soyweiser deleted the Soyweiser:proper_fuel branch Mar 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.