Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMore names and backer name genders #6830
Conversation
This comment has been minimized.
This comment has been minimized.
|
This came up in #3538. We never did make that topic, though, IIRC. Should best get on that. |
kevingranade
merged commit b0f349b
into
CleverRaven:master
Mar 23, 2014
1 check passed
default
This has been rescheduled for testing as the 'master' branch has been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SeanMirrsen commentedMar 21, 2014
Continuing from discussion here: http://smf.cataclysmdda.com/index.php?topic=5809
This is an updated en.json with a good many thousand unique given and family names added in, plus genders assigned to backer names to prevent clearly male names from appearing on female characters.
This still leaves the matter of the flat chance of backer names being chosen over generated names an issue, and even exacerbates it for female characters, as with that system every time a backer name gets selected, it gets pulled from a much narrower list of names. I still can't compile the game whole to see what can be done about that (altering the backer/random name distribution et al), but in the meantime this should provide enough random names that any time a random name ends up being selected, you're almost guaranteed a unique one.