Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic railroad track map tiles #6925

Closed
wants to merge 12 commits into from

Conversation

Projects
None yet
10 participants
@Wuzzy2
Copy link
Contributor

commented Mar 26, 2014

This adds some new terrain types and (over)map tiles to C:DDA. Those are all railroad-related.

New terrain types are: railroad tie (several directions), railroad track, buffer stop, railway crossing signal, crossbuck (wooden or metal).
New map tiles are: Straight rail, curved rail, rail ending with buffer stop, railway crossing (with crossbuck or railway crossing signal) and 2 kinds of railroad bridges.
The railway crossing signal, buffer stop and the crossbucks are smashable for wood or metal. The signal drops cheap electronics.

A (not accurate anymore) preview is here: http://smf.cataclysmdda.com/index.php?topic=5678.msg103528#msg103528

Please note there are no junctions for railroad tracks; these have been blacklisted.

To test, open the debug menu’s map editor and try everything with the word “rail” in it.

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2014

This is amazing!

@WeendVidente

This comment has been minimized.

Copy link

commented Mar 26, 2014

Good work!

Wuzzy
@dwarfkoala

This comment has been minimized.

Copy link

commented Mar 26, 2014

One thing I notice is that the railroads themselves are not disassemblable
for rails.

Rails, of course, are extremely powerful ammo for railguns.

On Wed, Mar 26, 2014 at 2:55 AM, WeendVidente notifications@github.comwrote:

Good work!

Reply to this email directly or view it on GitHubhttps://github.com//pull/6925#issuecomment-38665693
.

@Wuzzy2

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2014

@dwarfkoala: I had this idea, too. But I don’t know how to disassemble terrain or if this is even possible.

@gimlet90210

This comment has been minimized.

Copy link

commented Mar 26, 2014

Railguns are named that because they are constructed of electrical rails that carry current to accelerate the projectile, not because they use railroad rails as ammo. Also a railroad rail weighs over 100 pounds - the spikes used to nail the rails to the railroad ties would be MUCH better ammunition - those weigh something like 8 to 12 ounces each...

Wuzzy
Tweaked the railroad curves so players would have to pass at least 2 …
…tiles to reach rail

The player would have to pass at least two tiles of rubble or railroad tie before being able to step on the rail. It does not matter if the rail is straight or curved. This does not cound for bridges and railroad crossings, of course.
@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Mar 26, 2014

So this adds map tiles but it doesn't actually spawn them?

@KA101

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2014

Would probably use the same general mapgen code as river generation, I'd think, since rail junctions are Out.

@BollandP

This comment has been minimized.

Copy link

commented Mar 26, 2014

This looks very impressive. Is it going to see some use in those subway/metro tunnels? I always found it awkward that those tunnels had no metal in them.

I hope we also get simple junctions/crossings in future development, perhaps dynamically generated by just overlaying the pieces. Proper junctions/switches need a lot of effort to implement believably and can wait.

@Wuzzy2

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2014

@Rivet-the-Zombie: Yes. I leave the task of map generation to others. :P xD

@KA101

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2014

@Rivet-the-Zombie: Yes. I leave the task of map generation to others. :P xD

Unfortunately we don't merge code that doesn't actually do anything. You've come this far: you're gonna need to take another step and work it into mapgen somehow. Feel free to look at the code for subway lines and rivers; those are probably the closest fits. I got my start from copying and creatively reusing existing code. It's an entirely valid way to learn.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Mar 26, 2014

As a more accessable alternative to trying to solve the (fairly difficult)
someone can make a railyard or similar environment. Also this doesn't
conflict with anything, so it can hang out as a PR and probably not
accumulate conflicts until someone does work it in.

@Wuzzy2 Wuzzy2 changed the title Basic railroad track map tiles Basic railroad track map tiles [WIP] Mar 28, 2014

@Wuzzy2

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2014

I added “[WIP]” to the title because the inclusion to the map generator is missing.

Wuzzy

@kevingranade kevingranade changed the title Basic railroad track map tiles [WIP] Basic railroad track map tiles Aug 27, 2014

@KA101 KA101 force-pushed the CleverRaven:master branch from a342a64 to 0da0595 Oct 30, 2014

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2015

This PR will probably not become mergeable. Closing.

@Coolthulhu Coolthulhu closed this Apr 23, 2015

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Apr 23, 2015

But the idea was solid. I'd love to see this concept revisited and completed.

@ZhilkinSerg ZhilkinSerg referenced this pull request Sep 4, 2017

Closed

[WIP] Railroads #21792

8 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.