Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rename qualities to more sensible names. #6934

Merged
merged 3 commits into from Mar 31, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@Sheco @SeanMirrsen @kevingranade @KA101 @Rivet-the-Zombie
@Sheco
Copy link
Contributor

commented Mar 26, 2014

Partial resolution for #6929

Chemical making is still pending.
data/json/tool_qualities.json Outdated
@@ -54,18 +54,18 @@
},{
"type" : "tool_quality",
"id" : "WRENCH",
"name" : "bolt screwing"
"name" : "bolting"

This comment has been minimized.

Sign in to view
Copy link
@Rivet-the-Zombie

Rivet-the-Zombie Mar 26, 2014

Member

Both of the 'bolting' entries seem grammatically weird. I can't think of a good alternative right off hand though.

This comment has been minimized.

Sign in to view
Copy link
@Sheco

Sheco Mar 26, 2014

Author Contributor

I agree, kevingranade said bolting was fine, but I don't know if the verb applies.

This comment has been minimized.

Sign in to view
Copy link
@KA101

KA101 Mar 26, 2014

Contributor

Wrenches turn the nut on the bolt as well as the bolt itself. (Hold one still and turn the other.) "Fastening"?

This comment has been minimized.

Sign in to view
Copy link
@kevingranade

kevingranade Mar 30, 2014

Member

"bolt turning" and "fine bolt turning"?

@Sheco Sheco changed the title Rename qualities to more sensible names. WIP: Rename qualities to more sensible names. Mar 26, 2014

@SeanMirrsen

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Mar 27, 2014

I actually had a rather different idea in mind. Posted here: #6954 just for the sake of not having to explain what it does. :P
@Sheco

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Mar 30, 2014

Bolt turning sounds better

ka101 was suggesting fastening, what do you think?
@kevingranade

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 30, 2014

Fastening is too generic, screws, bolts, rivets, staples, welds, and glue are all fasteners.
@SeanMirrsen

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Mar 30, 2014

You could go for the accurate "rotary fastening tool" definition, but I think something like a "bolt fastening tool" would work better and be less confusing.
@KA101

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Mar 30, 2014

"Bolt turning" is fine IMO, go with that.
@Sheco

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Mar 31, 2014

I renamed the quality IDs to further remove traces of the "gunsmithing..." names (which were replaced with "fine" qualities), and to better match the ID with the name, to avoid having confusing IDs.

@kevingranade kevingranade merged commit 25b0db9 into CleverRaven:master Mar 31, 2014
1 check passed

1 check passed

default
Details

@Sheco Sheco deleted the Sheco:rename-qualities2 branch Mar 31, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.