Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upNew font colors for mixed (positive/negative) traits and threshold traits #6970
Conversation
added some commits
Mar 28, 2014
This comment has been minimized.
This comment has been minimized.
|
Great! |
kevingranade
merged commit 6941d3a
into
CleverRaven:master
Mar 31, 2014
1 check passed
default
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Wuzzy2 commentedMar 28, 2014
This adds two more colors to the list of traits in the player “window”, in order to make it a little bit more readable, aside from the current colors green (positive trait), yellow (neutral/indifferent trait) and red (negative trait).
a) Threshold traits/mutations are shown in white color.
b) Traits which have positive as well as negative effects are now shown in pink color.
Note this differs from neutral (“yellow”) traits which have no or very little effects.
In order to enable b), a new variable for traits has been added: mixed_effect.
This is a boolean which, if true, declares a trait having positive and negative effects.
The “default” procedure of selecting green/red/yellow color based on its points value is ignored then. This is purely declarative and only used for the player window (at the moment).
A very brief documentation is provided in JSON_INFO.md.
The following traits count as mixed:
If you know any other trait I’ve forget, please tell me! I am not sure if I should add Mood Swings.