Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New font colors for mixed (positive/negative) traits and threshold traits #6970

Merged
merged 5 commits into from Mar 31, 2014

Conversation

Projects
None yet
3 participants
@Wuzzy2
Copy link
Contributor

commented Mar 28, 2014

This adds two more colors to the list of traits in the player “window”, in order to make it a little bit more readable, aside from the current colors green (positive trait), yellow (neutral/indifferent trait) and red (negative trait).

a) Threshold traits/mutations are shown in white color.
b) Traits which have positive as well as negative effects are now shown in pink color.
Note this differs from neutral (“yellow”) traits which have no or very little effects.

In order to enable b), a new variable for traits has been added: mixed_effect.
This is a boolean which, if true, declares a trait having positive and negative effects.
The “default” procedure of selecting green/red/yellow color based on its points value is ignored then. This is purely declarative and only used for the player window (at the moment).

A very brief documentation is provided in JSON_INFO.md.

The following traits count as mixed:

  • Tentacle Arms
  • Tentacle Rakes
  • Leg Tentakles
  • Tentacle Bracing
  • Ectothermic
  • Growling Voice
  • Hissing Voice
  • Snarling Voice
  • Hooves
  • Curled Horns
  • Pointed Horns
  • Huge
  • Freakishly Huge
  • Inconveniently Large
  • Large Talons
  • Mandibles
  • Lupine Muzzle
  • Ursine Muzzle
  • Reptilian Muzzle
  • Paws
  • Saber Teeth
  • Chitinous Armor
  • Genetically Unstable
  • Hollow Bone
  • Antlers
  • Beak
  • Rubbery Limbs (BENDY2)
  • Rubbery Limbs (BENDY3)
  • Bovine Snout
  • Toe Talons
  • Shell
  • Thick Scales

If you know any other trait I’ve forget, please tell me! I am not sure if I should add Mood Swings.

Wuzzy added some commits Mar 28, 2014

Wuzzy
Let traits with mixed effects appear in magenta font.
This adds a new element to the trait data structure: mixed_effect.
If this is true it is used to manually declare that some trait has both
positive and negative effects. This only affects the player UI.
Wuzzy
Fixed bug in which "mixed_effect" color of traits reset to default co…
…lor if "TRAITS" was selected in UI.

Also changed the mixed_effect color to pink.
@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2014

Great!

@kevingranade kevingranade merged commit 6941d3a into CleverRaven:master Mar 31, 2014

1 check passed

default
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.