Removed encumbrance from holsters/quivers/sheaths/scabbards

[John-Candlebury]

Returned those items to the wont cover any part of the body status they had before. IMO they layer pretty badly under the current system. As an example wearing two holsters will end with you having one encumbrance (combine it with backpack and you'll have 3!) kinda excessive me thinks. I don't really think wearing two holsters should carry any penalty at all.

Not to mention that game play wise those items are kinda useless if they encumber you. Who would pick the combination of holster and lightweight storage item if a backpack offers double the carrying capacity for the same encumbrance?

[illi-kun]

Good point, quivers are useless in current system, because increased encumbrance from it is very serious penalty comparing with possible benefit (excluded volume of 20 arrows).

[kevingranade]

The other end of the question is whether it's reasonable to wear every
affected item with 0 encumbrance, is that the case?
We might want some compromise setting similar to tight.

[John-Candlebury]

The other end of the question is whether it's reasonable to wear every
affected item with 0 encumbrance, is that the case?
We might want some compromise setting similar to tight.

Well obviously no. I still prefer that alternative over the current massive encumbrance penalty, though.

Ideally I think the zero encumberance items should get away with some sort of slot system. After which extra items placed will start factoring in the encumbrance calculations. So you could wear a holster and a dump pouch without a penalty, but you cant get away with wearing two dump pouches over two fanny packs.

[kevingranade]

I was hoping to avoid explicit layers, but that might end up being
necessary, off the top of my head we have
Under, (thirt, socks, boxers, glove liners)
Default (shirt, pants, dress, gloves, skirt, shoes)
Over (coats, coveralls, glove shells, galoshes)
Strapped (belts, pouches, backpacks, hosters)
That might cover everything, but I don't want to make people update all the
freaking wearables.

[Rivet-the-Zombie]

I like @kevingranade's idea for defined layers, and agree that it seems like a lot of work. Still might be worth considering at some point.

@John-Candlebury what about the rifle slings? Those have a ridiculous amount of encumbrance, despite being intended to make carrying a rifle more comfortable. Perhaps they should go on this list as well? That being said, I like this PR.

[John-Candlebury]

Agreed with a rifle sling being a generally horrible thing to carry, through the reason to actually haul one of those around in game comes to mind when we can store our guns in our backpacks for a much less reduced encumbrance.

Holsters , however, do bother me a lot, how come carrying two holsters on your belt or under your shoulders and then putting a backpack on is as encumbering as hauling a duffel bag around everywhere you go? I'd say that such thing makes holsters completely useless.

[Rivet-the-Zombie]

I'll agree with that. Perhaps we should revisit the rifle slings and add a fancier version that's actually comfortable to wear, since the current one is a bedsheet tied to your weapon.

[John-Candlebury]

Dangit I realized that I read your comment completely wrong! (Sorry my bad English is generally bad)

Actually, I think that while not completely realistic, a 0 encumberance rifle sling would be neat thing to have gameplay wise, but I wouldn't know how to get around to adding those if you expect them to work like holsters

[Rivet-the-Zombie]

They're already in the game. Search for makeshift_sling to locate it.

I was suggesting that their encumbrance be reduced or removed as well and/or a better version of the sling that isn't literally a sheet tied to a rifle. Also maybe slightly encumbering, crude/makeshift holsters/sheaths/scabbards that day zero characters could cobble together out of cheap materials along the same lines as the current makeshift rifle sling without needing any recipes or advanced skills.

Actually, I think I'll merge this and continue the idea as I've outlined here in a PR of my own. I like this PR, @John-Candlebury!

[Zireael07]

I like the layers idea, @kevingranade. Worth exploring in a separate PR.

[kevingranade]

One thing I thought of to at least amortize if not reduce the workload is
we could add those layers one at a time, and only as specifically needed.
We already have the tight layer, I believe over already has a flag, but not
layering logic, we could add the "belted" layer to address this issue, if
we decide the status quo is insufficient for a particular type of clothing,
we can add a layering flag then.
The main issue I have with this pr is that players will load up with
every holster and scabbard item affected. To me that's worse than not
encouraging holster use.

[KA101]

OVERSIZE isn't a "layer" per se but rather a "don't check this for mutation-based incompatibiity" flag.

As it was, players were loading 2 of each item because slotless carrying-capacity is one of the best things in the game. Restricting it to strictly what the item's designed to carry was a good move to dial that back: two holsters allowing two handguns and only two handguns (rather than 6 volume) makes holsters less of a no-brainer.

[illi-kun]

Hey @kevingranade, here is a new advanced armor layer screen for your idea:

(updated scroll bar + fixed typo with army jacket. Good eye, @KA101!)

[KA101]

armor UI screen, looks Nifty

Can't tell whether the army jacket there is regular or belted. Aside from that, seems workable. I presume it'd still let you relayer your stuff manually if you want.

[Zireael07]

@illi-kun: This is great!

[illi-kun]

It looks like we can revert these changes since the expanded layering is introduced. Any comments?