Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sound capability to the game. #7216

Merged
merged 1 commit into from Apr 13, 2014

Conversation

Projects
None yet
4 participants
@CIB
Copy link
Contributor

commented Apr 13, 2014

Licensing issues: The test soundtracks are taken from http://smf.cataclysmdda.com/index.php?topic=1483.msg16972#msg16972 but there are no explicit licenses anywhere?! Why host a music submission contest if you don't ask people to submit content under the appropriate license? =/

Other than that, this should be almost good to go in. I'm just tracking down an obnoxious bug where only the first item of a playlist is ever played.

@John-Candlebury

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2014

Ha.

Awesomesauce.

@CIB

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2014

Bug found and fixed. Good to go(except licensing stuff).

@kevingranade

This comment has been minimized.

Copy link
Member

commented Apr 13, 2014

If they're submitted for DDA specifically, they're implicitly CC-BY-SA 3.0, just like all the code and tile contributions.

@CIB

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2014

Does "posting a soundcloud link to a forum thread asking for submissions" count as "submitted for DDA specifically", though?

EDIT: I think maybe GlyphGryph would know more about this. Seems the submissions might've been made directly to him or something.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Apr 13, 2014

Also your makefile doesn't work here, needs -I, -L and -l flags

@kevingranade

This comment has been minimized.

Copy link
Member

commented Apr 13, 2014

I'd say yes, due to, "Note that this is only for original pieces built specifically for the game."
I agree it could have been clearer.

@kevingranade kevingranade merged commit e44a054 into CleverRaven:master Apr 13, 2014

@kevingranade

This comment has been minimized.

Copy link
Member

commented Apr 13, 2014

Considering the size, I think most of the music should be distributed as a separate sound pack anyway.

@CIB

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2014

Considering the size, I think most of the music should be distributed as a separate sound pack anyway.

Yeah, definitely. Could probably get them smaller by using lower encoding quality, but it's more straightforward to just distribute them separately, and git doesn't really make much sense for managing them anyway. Reason I included 2 in the PR is more to show the feature off. =P

@KA101

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2014

You needed to include some sound, CIB. As Kevin's said, we don't merge code that doesn't do anything. ;-)

@kevingranade kevingranade changed the title Added sound capability to the game. [WIP] Added sound capability to the game. Aug 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.