Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded sound capability to the game. #7216
Conversation
This comment has been minimized.
This comment has been minimized.
|
Ha. Awesomesauce. |
This comment has been minimized.
This comment has been minimized.
|
Bug found and fixed. Good to go(except licensing stuff). |
This comment has been minimized.
This comment has been minimized.
|
If they're submitted for DDA specifically, they're implicitly CC-BY-SA 3.0, just like all the code and tile contributions. |
This comment has been minimized.
This comment has been minimized.
|
Does "posting a soundcloud link to a forum thread asking for submissions" count as "submitted for DDA specifically", though? EDIT: I think maybe GlyphGryph would know more about this. Seems the submissions might've been made directly to him or something. |
This comment has been minimized.
This comment has been minimized.
|
Also your makefile doesn't work here, needs -I, -L and -l flags |
This comment has been minimized.
This comment has been minimized.
|
I'd say yes, due to, "Note that this is only for original pieces built specifically for the game." |
kevingranade
merged commit e44a054
into
CleverRaven:master
Apr 13, 2014
This comment has been minimized.
This comment has been minimized.
|
Considering the size, I think most of the music should be distributed as a separate sound pack anyway. |
This comment has been minimized.
This comment has been minimized.
Yeah, definitely. Could probably get them smaller by using lower encoding quality, but it's more straightforward to just distribute them separately, and git doesn't really make much sense for managing them anyway. Reason I included 2 in the PR is more to show the feature off. =P |
This comment has been minimized.
This comment has been minimized.
|
You needed to include some sound, CIB. As Kevin's said, we don't merge code that doesn't do anything. ;-) |
CIB commentedApr 13, 2014
Licensing issues: The test soundtracks are taken from http://smf.cataclysmdda.com/index.php?topic=1483.msg16972#msg16972 but there are no explicit licenses anywhere?! Why host a music submission contest if you don't ask people to submit content under the appropriate license? =/
Other than that, this should be almost good to go in. I'm just tracking down an obnoxious bug where only the first item of a playlist is ever played.