Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation update #7397

Merged
merged 3 commits into from Apr 26, 2014

Conversation

Projects
None yet
3 participants
@VlasovVitaly
Copy link
Contributor

commented Apr 25, 2014

Fix update script(s) and update translation.

@kevingranade kevingranade merged commit aaad0da into CleverRaven:master Apr 26, 2014

1 check passed

default
Details

@VlasovVitaly VlasovVitaly deleted the VlasovVitaly:fix-translation-update branch Apr 26, 2014

@VlasovVitaly VlasovVitaly referenced this pull request Apr 26, 2014

Merged

Fix pot file #7418

@KA101

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2014

For future reference, what's involved in checking/parsing these? I didn't merge it because I'm not familiar with the language-handling system.

@VlasovVitaly

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2014

Almost all errors are controlled by lang/update-pot script. Script tells to contributor where error is. If no errors, it's safe to commit and merge.
But there is one class of errors that not checked by script. It's unicode decoding error. Sometime pot file has weird chars which can't be encoded to utf8. Right now I don't know how to check this properly.

So, if someone makes PR with translation update that's mean it is save to merge for 90% because update-pot check sources for errors(except utf8 encoding).

After merging all translation systems(launchpad transifex) will be update templates automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.