Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export it stationary to json #7480

Merged

Conversation

Projects
None yet
3 participants
@BevapDin
Copy link
Contributor

commented Apr 30, 2014

Enable items of type it_stationary to be loaded from json.

Before merging this we should speak about the names that got used here:

it_stationary (C++ class name) - it's a flyer (item not furniture). This should be changed, as should STATIONARY_ITEM (type of the json object, like GENERIC). Maybe something like NOTE, RANDOM_TEXT_ITEM, or something?

I extended the snippet loading to allow arrays instead of having each snippet in a separate entry. This can be used to create the newspaper item from the forum: http://smf.cataclysmdda.com/index.php?topic=6218.0

BevapDin added some commits Apr 30, 2014

Allow snippet texts to be read from an array
instead of having each entry in a separate json object.
Item_factory: add support for loading items of type it_stationary.
- Simplify the constructor of it_stationary to make it usable in Item_factory (all the values of it_type are loaded _after_ the object has been created).
@KA101

This comment has been minimized.

Copy link
Contributor

commented May 3, 2014

OK, I don't fully understand what's going on in this one. Should we pull the trigger or not?

@BevapDin

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2014

It is working as fine. Only the names bothered me: STATIONARY_ITEM/it_stationary for things like fliers? But if nobody objects, I'm fine with it.

@KA101

This comment has been minimized.

Copy link
Contributor

commented May 4, 2014

Just labelled it. If I don't hear any objections by the time I come looking again, I'll merge it--there's a newspaper-maker eagerly awaiting streamlined code.

@kevingranade kevingranade merged commit 68ff68b into CleverRaven:master May 4, 2014

1 check passed

default
Details

@BevapDin BevapDin deleted the BevapDin:export-it_stationary-to-json branch May 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.