Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upExport it stationary to json #7480
Conversation
BevapDin
added some commits
Apr 30, 2014
This comment has been minimized.
This comment has been minimized.
|
OK, I don't fully understand what's going on in this one. Should we pull the trigger or not? |
This comment has been minimized.
This comment has been minimized.
|
It is working as fine. Only the names bothered me: |
KA101
added
the
Suggestion (Discuss)
label
May 4, 2014
This comment has been minimized.
This comment has been minimized.
|
Just labelled it. If I don't hear any objections by the time I come looking again, I'll merge it--there's a newspaper-maker eagerly awaiting streamlined code. |
kevingranade
merged commit 68ff68b
into
CleverRaven:master
May 4, 2014
1 check passed
default
Details
BevapDin
deleted the
BevapDin:export-it_stationary-to-json
branch
May 5, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BevapDin commentedApr 30, 2014
Enable items of type
it_stationaryto be loaded from json.Before merging this we should speak about the names that got used here:
it_stationary(C++ class name) - it's a flyer (item not furniture). This should be changed, as shouldSTATIONARY_ITEM(type of the json object, likeGENERIC). Maybe something likeNOTE,RANDOM_TEXT_ITEM, or something?I extended the snippet loading to allow arrays instead of having each snippet in a separate entry. This can be used to create the newspaper item from the forum: http://smf.cataclysmdda.com/index.php?topic=6218.0