Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upgettext bugfixes and smallfixes. #7629
Conversation
VlasovVitaly
added some commits
May 13, 2014
BevapDin
reviewed
May 13, 2014
src/crafting.cpp
Outdated
| @@ -787,10 +787,10 @@ recipe *game::select_crafting_recipe() | |||
| mvwprintz(w_data, i - recmin, 2, c_dkgray, ""); // Clear the line | |||
| if (i == line) { | |||
| mvwprintz(w_data, i - recmin, 2, (available[i] ? h_white : h_dkgray), | |||
| item_controller->find_template(current[i]->result)->name.c_str()); | |||
| _(item_controller->find_template(current[i]->result)->name.c_str())); | |||
This comment has been minimized.
This comment has been minimized.
BevapDin
May 13, 2014
Contributor
That should be
item_controller->find_template(current[i]->result)->nname(1).c_str()
This comment has been minimized.
This comment has been minimized.
|
Just this one or all? Why? Please, give me more info |
This comment has been minimized.
This comment has been minimized.
|
All of them. This is the proper use of the pluralization system, introduced and explained there: #7167 (comment) In short: Don't use |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
ok. I hope this PR is finished. |
This comment has been minimized.
This comment has been minimized.
|
Looks fine |
KA101
self-assigned this
May 13, 2014
KA101
merged commit f307b6b
into
CleverRaven:master
May 13, 2014
1 check passed
default
This has been rescheduled for testing as the 'master' branch has been updated.
VlasovVitaly
deleted the
VlasovVitaly:fix-gettext-msgs
branch
May 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
VlasovVitaly commentedMay 13, 2014
VlasovVitaly@6fd9b83 Fixes very hidden bug:
This happens only in non-English languages. This string printed when programm required empty string from gettext. Commit fix that.
VlasovVitaly@21d6b3d Fixes small translations errors.
VlasovVitaly@6b1dfb4 Show translated names in crafting menu.