Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRandom character points fix #7661
Conversation
added some commits
May 16, 2014
KA101
self-assigned this
May 17, 2014
This comment has been minimized.
This comment has been minimized.
|
This will make it more difficult to leave char points at 1K and still get reasonable results from Play Now!, but not the first time we've sacrificed for the good of the playerbase. ;-) |
KA101
merged commit 7c828f5
into
CleverRaven:master
May 17, 2014
1 check passed
default
This has been rescheduled for testing as the 'master' branch has been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Wuzzy2 commentedMay 16, 2014
See http://smf.cataclysmdda.com/index.php?topic=6338.0.
The random character creation did not use INITIAL_POINTS and MAX_TRAIT_POINTS. Instead, a default INITIAL_POINTS of 8 and MAX_TRAIT_POINTS of 12 were assumed. This PR fixes this, random characters now start with the correct values.
However, there is still a small quirk, for very large INITIAL_POINTS, it can happen that there are some leftover points.