Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upIts curtains #7713
Conversation
kevingranade
added some commits
May 21, 2014
This comment has been minimized.
This comment has been minimized.
|
Great! |
This comment has been minimized.
This comment has been minimized.
|
Hooray! |
KA101
reviewed
May 21, 2014
src/iexamine.cpp
Outdated
| long amount = helper::to_int( | ||
| string_input_popup( | ||
| popupmsg, 20, helper::to_string_int(max_amount), "", "", -1, true)); | ||
| const std::string popupmsg = string_format(_("Put how many of the %s into the %s?"), |
This comment has been minimized.
This comment has been minimized.
KA101
May 21, 2014
Contributor
Uh, this seems like a candidate for the translation team's WTF thread. Might help to have a comment?
This comment has been minimized.
This comment has been minimized.
kevingranade
May 22, 2014
Author
Member
Good catch, added some brief explanations of several of the forge loading messages.
KA101
self-assigned this
May 23, 2014
KA101
merged commit 373f544
into
CleverRaven:master
May 23, 2014
1 check passed
default
Details
kevingranade
deleted the
kevingranade:its-curtains
branch
Mar 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedMay 21, 2014
Peek through the curtains, or tear them down and make a pretty dress!
Peek can now be applied to other terrain too, just call it with g->peek(x, y); where x and y are the location of the terrain you can peek through.