Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove smashing #7743
+315
−330
Conversation
kevingranade
added some commits
May 25, 2014
KA101
self-assigned this
May 25, 2014
KA101
merged commit 576b298
into
CleverRaven:master
May 26, 2014
1 check passed
default
This has been rescheduled for testing as the 'master' branch has been updated.
kevingranade
deleted the
kevingranade:improve-smashing
branch
Mar 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedMay 25, 2014
What started as a quick fix to allow double-smashing to clear windows turned into a refactor of map::bash(), scattered code cleanups, and several bugfixes.