[Asset] Curtainless window terrain #7749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curtainless window asset at KA101's request. Not implemented in any existing code because: A) It would leave windows unable to be barricaded/taped/whatever after tearing down windows B) Adding another construction option for 'barricade/tape/whatever curtainless window' would be confusing since it's called 'closed window' and 'open window' C) I didn't want to dive into the code to allow multiple pre-terrain types for one construction because I don't know how (in order to fix B and then indirectly fix A) I leave this in the hands of more skilled coders...
|
OK, you'd asked on IRC whether it'd be at all useful, and I said to throw it here or on the forums. :-/ Sorry for the confusion, I guess. |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curtainless window terrain asset at KA101's request.
Not implemented in any existing code because:
A) It would leave windows unable to be barricaded/taped/whatever after tearing down curtains
B) Adding another construction option for 'barricade/tape/whatever curtainless window' would be confusing since it's called 'closed window' and 'open window'
C) I didn't want to dive into the code to allow multiple pre-change terrain types for one construction because I don't know how (in order to fix B and then indirectly fix A)
I leave this in the hands of more skilled coders...
(#7741)