Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd check for empty default ammo type when spawning matching ammo for guns #7789
Conversation
KA101
assigned
KA101
and unassigned
KA101
May 30, 2014
kevingranade
merged commit 72196c8
into
CleverRaven:master
May 31, 2014
BevapDin
deleted the
BevapDin:fix-item-spanwammo
branch
May 31, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BevapDin commentedMay 30, 2014
The ammo type "darts" does not come with a default ammo item type. Because the blowgun is in an item group ("homeguns") which should spawn the matching ammo for guns (
guns_with_ammo:true), this would spawn an item with an empty string as ident ("darts" has this as default ammo), this shows up as "undefined-s".This PR adds a check to prevent this behavior. One could additionally define a default ammo item type for darts, but this kind of error might come up for other guns, too.