Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pimped death screen. #7818

Merged
merged 2 commits into from Jun 5, 2014

Conversation

Projects
None yet
8 participants
@OzoneH3
Copy link
Member

commented Jun 2, 2014

@Lucasargh

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2014

@MattAmmann

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2014

I like how the cross is pretty banged up and is clearly makeshift. Nice work!

Does the kill counter run into the side of the cross if the player has more than 9999 kills? Might want to make it a tiny bit wider, if so.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2014

Aside from the whole cross=christian thing, yeah, looks Nifty. A rounded-slab or other non-sectarian grave marker would be perfectly acceptable and I'd be glad to merge it.

(Provided it works, doesn't break other things, etc, obviously.)

int iNameLine = 0;
int iInfoLine = 0;

if (!(u.has_trait("CANNIBAL") || u.has_trait("PSYCHOPATH") || u.has_trait("MASOCHIST"))) {

This comment has been minimized.

Copy link
@KA101

KA101 Jun 3, 2014

Contributor

OK, the inversion for Cannibals/Psychopaths is mildly amusing. Masochism shouldn't qualify, though, and as I stated earlier it's still christian-centric so I'd rather genericize the imagery entirely.

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2014

Make it a tombstone instead of a cross as a way of genericizing it?

@latogato

This comment has been minimized.

Copy link

commented Jun 3, 2014

Yes, change it into a non-religious tombstone.
A " killed by in the , while " would be nice, but hard to add addition.
Like the Nethack death screen:
http://youlearnsomethingnew.com/wp-content/uploads/2013/10/nethacktombstone.gif

"Here lies McAwesome, killed by a Zombear in the city, while slept"

@OzoneH3

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2014

Dereligified version is up.

@latogato: Since there is no easy way to find you what exactly killed you, this would be quite hard to make, also there are no real places with names either other than house or hospital maybe!?

I could see some kind of score going on the stone as well in the future.

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2014

Can't wait for this to make it in!

@KA101

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2014

OK, I'll put up a forum post soliciting alternate designs for other religions then. There are some minor issues (third bible, non-sectarian isn't "round" at the bottom) but I can fix those in the merge.

@vache

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2014

Side note, there's now a holybook_bible3

@KA101

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2014

Side note, there's now a holybook_bible3

I know, I merged it. ;-) Trivial fix.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Jun 4, 2014

Fyi towns do have names, they just aren't used for anything.

@KA101 KA101 self-assigned this Jun 5, 2014

@KA101

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2014

Asked and nobody had any religious-accommodation requests, so pulling for merge processing.

@KA101 KA101 merged commit dc510ce into CleverRaven:master Jun 5, 2014

@OzoneH3 OzoneH3 deleted the OzoneH3:rip branch Jul 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.