Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround mingw breakage #8097

Merged
merged 2 commits into from Jun 30, 2014

Conversation

Projects
None yet
5 participants
@kevingranade
Copy link
Member

commented Jun 30, 2014

Replaced the to_string() call with stringstream operations.
While I was at it, added an official listing of support for various compilers.

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Jun 30, 2014

Great now I can't readily test this because I patched MinGW.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2014

I'll switch it back. Hang on.

@KA101 KA101 self-assigned this Jun 30, 2014

@KA101

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2014

Um, it doesn't seem to work: http://pastebin.com/143LJBda

(I'd appreciate someone else testing this as well.)

@KA101 KA101 removed their assignment Jun 30, 2014

@kevingranade

This comment has been minimized.

Copy link
Member Author

commented Jun 30, 2014

Wow, I have no idea where all that came from, I'm really confused now.

@i2amroy

This comment has been minimized.

Copy link
Member

commented Jun 30, 2014

to_string() also stops Cygwin from compiling, so hopefully whatever we do to fix this will also fix the Cygwin version.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2014

Could be changing the compiler screwed something up in my local repo: C::B recorded the compiler change as a change to the project file (I declined to save it, but still). That's one of the reasons I'd appreciate others compiling this.

@vache

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2014

I can roll back my MingW patch and pull this and test it when I get home.

@i2amroy

This comment has been minimized.

Copy link
Member

commented Jun 30, 2014

This fixes the Cygwin version. My bet would be that you screwed up your local somehow KA101 since I'm not seeing any of those errors at all.

@i2amroy i2amroy merged commit 2f4a68e into CleverRaven:master Jun 30, 2014

i2amroy added a commit that referenced this pull request Jun 30, 2014

@KA101

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2014

Yeah, was a build issue here. Fixed now. Thanks.

@BevapDin BevapDin referenced this pull request Oct 2, 2014

Merged

[Ready] [CR] Jumper cables! #9374

11 of 11 tasks complete

@kevingranade kevingranade deleted the kevingranade:workaround-mingw-breakage branch Mar 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.