Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upWorkaround mingw breakage #8097
Conversation
kevingranade
added some commits
Jun 29, 2014
This comment has been minimized.
This comment has been minimized.
|
Great now I can't readily test this because I patched MinGW. |
This comment has been minimized.
This comment has been minimized.
|
I'll switch it back. Hang on. |
KA101
self-assigned this
Jun 30, 2014
This comment has been minimized.
This comment has been minimized.
|
Um, it doesn't seem to work: http://pastebin.com/143LJBda (I'd appreciate someone else testing this as well.) |
KA101
removed their assignment
Jun 30, 2014
This comment has been minimized.
This comment has been minimized.
|
Wow, I have no idea where all that came from, I'm really confused now. |
This comment has been minimized.
This comment has been minimized.
|
to_string() also stops Cygwin from compiling, so hopefully whatever we do to fix this will also fix the Cygwin version. |
This comment has been minimized.
This comment has been minimized.
|
Could be changing the compiler screwed something up in my local repo: C::B recorded the compiler change as a change to the project file (I declined to save it, but still). That's one of the reasons I'd appreciate others compiling this. |
This comment has been minimized.
This comment has been minimized.
|
I can roll back my MingW patch and pull this and test it when I get home. |
This comment has been minimized.
This comment has been minimized.
|
This fixes the Cygwin version. My bet would be that you screwed up your local somehow KA101 since I'm not seeing any of those errors at all. |
i2amroy
merged commit 2f4a68e
into
CleverRaven:master
Jun 30, 2014
i2amroy
added a commit
that referenced
this pull request
Jun 30, 2014
This comment has been minimized.
This comment has been minimized.
|
Yeah, was a build issue here. Fixed now. Thanks. |
kevingranade commentedJun 30, 2014
Replaced the to_string() call with stringstream operations.
While I was at it, added an official listing of support for various compilers.