Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix profession item listing #8132
Conversation
kevingranade
added some commits
Jul 4, 2014
This comment has been minimized.
This comment has been minimized.
|
Good fix! I didn't like removing stuff from those professions, and this is a much better fix. |
This comment has been minimized.
This comment has been minimized.
|
I tested this PR and it fixes the issue with the profession list crashing in the "patriot" entry. |
Rivet-the-Zombie
added a commit
that referenced
this pull request
Jul 4, 2014
Rivet-the-Zombie
merged commit 724dd0e
into
CleverRaven:master
Jul 4, 2014
kevingranade
deleted the
kevingranade:fix-profession-item-listing
branch
Mar 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedJul 4, 2014
Fixed the source of the crash, and thus I'm able to restore the larger list of items for the professions that were triggering the breakage.
Still needs to be updated to show that there are more items not being displayed.
Alternately, collapsing e.g. beer, beer, beer, beer into beer (x4) would be good.