Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large Tent #8377

Merged
merged 3 commits into from Jul 31, 2014

Conversation

Projects
None yet
2 participants
@jc6036
Copy link
Contributor

commented Jul 29, 2014

I've added a large tent to the game, with a floor space of 3x3 and a total space of 5x5.

To accomplish this, I added:

  • An iuse function for the tent
  • An iexamine function to take down the tent
  • Two new furniture objects, groundsheets
  • The actual json data in item_groups.json, furniture.json, and tools.json

The tent has 40 volume, making it just troublesome enough to outweigh its boon of space. The spawn rate, however, is identical to the smaller personal tent.

if (!g->m.has_flag("FLAT", posx + i, posy + j) ||
g->m.has_furn(posx + i, posy + j)) {
add_msg(m_info, _("You need a 5x5 flat space to place a tent."));
return 0;

This comment has been minimized.

Copy link
@KA101

KA101 Jul 29, 2014

Contributor

Should probably be "this tent" so folks don't get confused between tents. Little thing, I know.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2014

Looks like it's set for mainline, not a mod. Not that I mind: this isn't outside DDA's scope, so no reason it couldn't be mainline. Just wanted to clarify that.

@jc6036

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2014

I was actually wondering if this was the correct spot to be honest. I appreciate the clarification.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2014

You want to throw code our way, this is the spot. Welcome to the hopper.

@KA101 KA101 self-assigned this Jul 29, 2014

@KA101

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2014

OK, not yet ready. You're gonna need to copy the damaged-tent code for this one, as currently yours is impervious to attack (whacking it with a machete did nothing; do the same to the small and it's Collapsed, in need of repair.)

@KA101 KA101 removed their assignment Jul 30, 2014

@jc6036

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2014

Okay, I'll begin on that shortly.

@jc6036

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2014

All finished up now.

@KA101 KA101 self-assigned this Jul 30, 2014

@KA101 KA101 merged commit cda1efe into CleverRaven:master Jul 31, 2014

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.

@jc6036 jc6036 deleted the jc6036:tent_mod branch Jul 31, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.