Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cold drinks! #8671

Merged
merged 5 commits into from Aug 24, 2014

Conversation

Projects
None yet
3 participants
@Rivet-the-Zombie
Copy link
Member

commented Aug 24, 2014

This PR gives minifriges the ability to chill certain foods (primarily
beverages) and give them the (cold) flag which improves their morale
boost by 50% - or gives them a small morale boost if they have a
negative morale value.
The cold flag wears off with time (about an hour out of the fridge) and
is tied to a new comestible flag ("EATEN_COLD") with all the relevant
morale calculations taken care of in player.cpp.

Rivet-the-Zombie added some commits Aug 24, 2014

Cold drinks!
This PR gives minifriges the ability to chill certain foods (primarily
beverages) and give them the (cold) flag which improves their morale
boost by 50% - or gives them a small morale boost if they have a
negative morale value.
The cold flag wears off with time (about an hour out of the fridge) and
is tied to a new comestible flag ("EATEN_COLD") with all the relevant
morale calculations taken care of in player.cpp.

@KA101 KA101 self-assigned this Aug 24, 2014

@Rivet-the-Zombie Rivet-the-Zombie changed the title Cold drinks! WIP - Cold drinks! Aug 24, 2014

@KA101 KA101 removed their assignment Aug 24, 2014

Fixes bugs in the PR.
Now to see about the extant bug - namely that comestibles in containers
hold their (hot) or (cold) status forever when left lying on the ground
and only properly lose it over time when carried.�
@Valkjosandi

This comment has been minimized.

Copy link

commented Aug 24, 2014

Can I suggest a moral penalty for cold foods like pizza, steak, and other things commonly eaten hot, or is that out if the scope of this pr?

Edit: corrected spelling of 'steak'

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2014

That's a bit more than what I'm doing with this PR.

I'll file the idea away for later, though.

@Valkjosandi

This comment has been minimized.

Copy link

commented Aug 24, 2014

Okay :) One more question, does the "it.fridge " condition refer strictly to the mini fridge or do fridges found in houses work too?

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2014

Just powered minifridges that have been turned on.

@KA101 KA101 self-assigned this Aug 24, 2014

@Rivet-the-Zombie Rivet-the-Zombie changed the title WIP - Cold drinks! Cold drinks! Aug 24, 2014

@KA101 KA101 merged commit 1fc648a into CleverRaven:master Aug 24, 2014

@Rivet-the-Zombie Rivet-the-Zombie deleted the Rivet-the-Zombie:cold-drinks branch Aug 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.