Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCold drinks! #8671
Conversation
Rivet-the-Zombie
added some commits
Aug 24, 2014
KA101
self-assigned this
Aug 24, 2014
Rivet-the-Zombie
changed the title
Cold drinks!
WIP - Cold drinks!
Aug 24, 2014
KA101
removed their assignment
Aug 24, 2014
This comment has been minimized.
This comment has been minimized.
Valkjosandi
commented
Aug 24, 2014
|
Can I suggest a moral penalty for cold foods like pizza, steak, and other things commonly eaten hot, or is that out if the scope of this pr? Edit: corrected spelling of 'steak' |
This comment has been minimized.
This comment has been minimized.
|
That's a bit more than what I'm doing with this PR. I'll file the idea away for later, though. |
This comment has been minimized.
This comment has been minimized.
Valkjosandi
commented
Aug 24, 2014
|
Okay :) One more question, does the "it.fridge " condition refer strictly to the mini fridge or do fridges found in houses work too? |
This comment has been minimized.
This comment has been minimized.
|
Just powered minifridges that have been turned on. |
KA101
self-assigned this
Aug 24, 2014
Rivet-the-Zombie
changed the title
WIP - Cold drinks!
Cold drinks!
Aug 24, 2014
KA101
merged commit 1fc648a
into
CleverRaven:master
Aug 24, 2014
Rivet-the-Zombie
referenced this pull request
Aug 24, 2014
Closed
Comestible flags for items in containers don't update until the item is picked up. #8676
Rivet-the-Zombie
deleted the
Rivet-the-Zombie:cold-drinks
branch
Aug 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Rivet-the-Zombie commentedAug 24, 2014
This PR gives minifriges the ability to chill certain foods (primarily
beverages) and give them the (cold) flag which improves their morale
boost by 50% - or gives them a small morale boost if they have a
negative morale value.
The cold flag wears off with time (about an hour out of the fridge) and
is tied to a new comestible flag ("EATEN_COLD") with all the relevant
morale calculations taken care of in player.cpp.