Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upWoodcraft expansion! #8781
Conversation
Rivet-the-Zombie
added some commits
Sep 1, 2014
kevingranade
added
the
validated
label
Sep 2, 2014
This comment has been minimized.
This comment has been minimized.
|
Yay!
|
This comment has been minimized.
This comment has been minimized.
|
Awesome! Great work there Rivet! Loving the many new recipes! |
This comment has been minimized.
This comment has been minimized.
|
Small nitpick, I think morel mushrooms only be identifiable at a decent survival skill level like it happens with the other types of mushroom. The rest is great. |
This comment has been minimized.
This comment has been minimized.
|
I went with having the morels identifiable on sight because a morel looks waaaay different from most other types of mushrooms. Their drawback is that you can't safely eat them raw. |
KA101
reviewed
Sep 2, 2014
| "time": 8000, | ||
| "reversible": false, | ||
| "autolearn": true, | ||
| "note": "the cooking oil isn't supposed to be expended since you can recycle it after frying the dandelions", |
This comment has been minimized.
This comment has been minimized.
KA101
reviewed
Sep 2, 2014
| "healthy" : 0, | ||
| "addiction_potential" : 0, | ||
| "nutrition" : 18, | ||
| "description" : "A tasty serving of cooked morel mushroom.", |
This comment has been minimized.
This comment has been minimized.
KA101
Sep 2, 2014
Contributor
I'd like to remove the "serving of" here: it makes me feel like "mushroom" should be plural, despite the fact that you're eating a single cooked/fried morel. Thus "A tasty cooked (or fried, for the fried version) morel mushroom."
This comment has been minimized.
This comment has been minimized.
pabrams
Sep 2, 2014
There's nothing wrong with the plurality (making mushroom plural would be wrong, I think, e.g. "A tasty serving of cooked carrot" - it doesn't matter how many carrots were used), but I agree that if a serving always consists of a single mushroom, then you might as well remove "serving of". You'd only need "serving of" if a serving consisted of more or less than exactly one mushroom. Like if you cooked mushroom(s) in a pot, mashed it up, then started serving that.
KA101
self-assigned this
Sep 3, 2014
KA101
added
the
ready for merge
label
Sep 3, 2014
This comment has been minimized.
This comment has been minimized.
|
It's crashing on picking pine trees, but that's probably the examine-crash. Picking dandelions worked OK but didn't seem to recognize the name_plural field--probably a glitch elsewhere. Recipes work well enough. Will test the shelter and then merge. |
KA101
merged commit 254c9e5
into
CleverRaven:master
Sep 3, 2014
1 check passed
Rivet-the-Zombie
deleted the
Rivet-the-Zombie:ever-eat-a-pine-tree-many-parts-are-edible
branch
Sep 3, 2014
This comment has been minimized.
This comment has been minimized.
|
Love it! <3 |
Rivet-the-Zombie commentedSep 2, 2014
new construction: improvised woodcraft shelter
new trees: pine trees - found in forests
new trees: dead pine trees - found in forests or caused by picking live pines
new food source: pinecones - found on the ground in forests or by picking pine trees
new flowers/food source: dandelions - found in meadows
new food source: morel mushrooms - found with other mushrooms when foraging
new food source: buckwheat - found by foraging
new food source: dahlia root - found by picking dahlias with a digging tool in your inventory
new food source: acorns - found by foraging and on the ground in forests
many new recipes, items, foods, and drinks
many modified recipes that use new ingredients