BatchCraft

[Robik81]

Adds feature of batch crafting into crafting menu.

1. open craft menu and select recipe
   

2. press [b]atch to generate batch screen for selected recipe
   

3. either select one of batch recipes, or return to previous screen by pressing [b]atch again

[i2amroy]

Seems like you've got some unused parameters present, but if you fix them (and this works, obviously) then I'm behind this totally. Batch crafting would be awesome.

[Rivet-the-Zombie]

Yes! I like the sound of this a lot.

[Robik81]

Working on these usused params, will have to break some template methods to avoid them.

[i2amroy]

Couldn't you just (void) them in the function? That works to suppress that particular warning without needing to break the template apart for everything else.

[KA101]

One last thing: make a note in the UI that pressing Batch again will cancel out of batch selection, please? Explanations of new features make good additions great!

[Robik81]

Done.

In case of bugs, I will swat them tomorrow. Need some sleeping :)

[KA101]

Schlaf gut. Since this is a great place for new bugs to crop up, gonna merge it separately.

[Zireael07]

YEEAH!

[kevingranade]

Looks like this was broken before, but this doesn't fix it. What you want is something like:

for( iter = conts.begin(); iter != conts.end() ) {
    if( iter->is_container_empty ) {
        // Do stuff
        iter = conts.erase( iter );
    } else {
        iter++;
    }
}

[Robik81]

I will check it out. While I was debugging it, it seemed to work just fine. It did not end in endless loop or something.

[kevingranade]

huh, why not?

[Robik81]

Mostly because it is paint in the ass to implement and it is fringe case. In function
void game::complete_craft()
calling consume_items(&u, *it, making->batch); returns list of used component, which is later used to populate component list in reversible items. Problem is, that in batch crafting, the consumed list is populated with all component for entire batch, which I cannot add to each result, obviously. And while I was thinking about how to separate it, I got a headache from it.

So, I thought that as long as I disable batch craft for these cases, it can be implemented later - if ever, to be honest. Reversible items are not typical examples of items you need to craft in bulk anyway.

[KA101]

Didn't have the time to give this the attention it needs, but fortunately Kevin's on the case. Thanks, Kevin.

[Robik81]

Depending on your containers, that code could indeed end in infinite loop. Thanks for catching it, Kevin.

Question:
Is disabled batch crafting for reversible items merge blocking?

[kevingranade]

No, that's an ok reason to put that off, and the error should result in
clear feature requests if people are bothered by it.

[Zireael07]

So this could get merged in, and reversible items could get added by another PR?