Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRoot safety-checking #9118
Conversation
kevingranade
added
the
(S2 - Confirmed)
label
Sep 19, 2014
This comment has been minimized.
This comment has been minimized.
|
Is there some sort of check to prevent the focus loss here from going into negative numbers? I don't see anything that looks like it would directly prevent it. |
This comment has been minimized.
This comment has been minimized.
|
No. Conversely, the previous rate could easily hit several times running. This reduces the rate at which one could lose focus, and further makes the loss contingent on an IN check. I can add an express check for whether the focus pool is >= 25 or so, if you'd prefer. |
This comment has been minimized.
This comment has been minimized.
|
Found a bug in Saprophage whilst on this: it wants water to go rotten first. Fixing that now. |
KA101
added
the
ready
label
Sep 19, 2014
Rivet-the-Zombie
added a commit
that referenced
this pull request
Sep 20, 2014
Rivet-the-Zombie
merged commit e71dd6f
into
CleverRaven:master
Sep 20, 2014
1 check passed
default
Details
kevingranade
removed
the
(S2 - Confirmed)
label
Sep 20, 2014
KA101
deleted the
KA101:soilfocus
branch
Sep 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
KA101 commentedSep 19, 2014
Fixes #9117. Thanks to Rivet and Kyriolexical Dino for reporting.