Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlays Tweak #9257

Merged
merged 1 commit into from Sep 26, 2014

Conversation

Projects
None yet
5 participants
@Robik81
Copy link
Contributor

commented Sep 26, 2014

Males and females can have separate overlays now.

Default (used when gender specific overlay is not defined):
overlay_worn_{ITEM_ID}
overlay_wielded_{ITEM_ID}
overlay_mutation_{MUTATION_ID}

Specific for male:
overlay_male_worn_{ITEM_ID}
overlay_male_wielded_{ITEM_ID}
overlay_male_mutation_{MUTATION_ID}

Specific for female:
overlay_female_worn_{ITEM_ID}
overlay_female_wielded_{ITEM_ID}
overlay_female_mutation_{MUTATION_ID}

Both have combat knife, tank top and horns mutation
gsoverlays

OverlaysTweak
Males and females can have separate overlays now.
@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2014

Woot!

@Mshock777

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2014

Will you be able to switch to different female tile and for it to use overlay_male tiles,
If not, it will be twice much work.
Also both standard characters will have problem wearing hats, and female - designing stuff around her hair.

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2014

@Mshock777 Erm... I don't understand what you mean. Can you elaborate more, please?

If male and female have same shape, you will use only default, except for few items where you explicitly want to differentiate.

If male and female have different shape, you will have to use gender specific or it will look weird on one or both of them, most likely. That is twice as much work, yes - except you can skip underpants for women and bikini for men and such... no need to have overlay for every possible combination IMO. Lot of items will need only small alterations like different position or angle. Still, more work than if you have only one shape, no question about that.

@Mshock777

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2014

i was thinking:
you can in menu choose between 2 options:

  1. Characters use old tiles and clothes are gender specific
  2. They use new tiles and clothes are the same
    Btw, if man wears women's clothes, I want him to see and feel accordingly, he is not getting away from it.
@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2014

Nope, no menu you can choose from.

Tileset maker will decide, if he wants to have male and female with same shape and one set of overlay tiles, or if he wants different shape for each gender and thus have to use two sets of overlay tiles.

This PR allows for more options. Without it, you had to make both genders with same shape, if you wanted to add overlays.

Btw, he can hide panties under trench coat anyway... ;-)

@Mshock777

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2014

I expressed it wrong, I was thinking about plan to make this option.
Also do you have a problem with clothes overlapping, when you don't want to, like pants overlapping coats, I addressed this issue somewhere but no one seemed to care.

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2014

You mean order discussion here? #8993
I didn't have this problem, because I tried only one piece of clothing. I will fix it if CIB does not do it himself.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Sep 26, 2014

@mshock are you saying you'd like one tile set to support different modes
of display? That sounds like a reasonable thing to do.

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2014

Tried it, overlapping can be solved like CIB suggested in Layering armor screen (+) on the first tab (Sort Armor << All >>).
If you sort your clothing here, it renders in that order.

gsoverlays02

@Mshock777

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2014

@Robik81 Yeah, it works, maybe leave it as plan for the future for game to render it properly by itself.

@kevingranade Well, I was just thinking that I would do clothing for new characters, and if there is option and someone to do it for old designs, I will be happy to see it in tileset.

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2014

Are you both talking about possibility to choose tile for you character (player_male / player_female) at the start of the game?

Crazy talk! :)

Shapes of these variants would have to be same, 1 shape for male and 1 shape for female... if you want overlays to work. You could change like colors of skin and hair.

Or you want to have option to 'on/off' overlays in options? But who would want to turn off overlays if the tileset supports it?

Robik is confused

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2014

@Mshock777 Ok I get it now, something like 2 tileset in 1, with some tiles used by both. That would be... complicated. And I don't see that much benefit, because so far, you are only one who is working on adding overlays. :)

While I am making some tiles, it is for testing purposes only, I certainly am not planning on making new tileset based on yours, just with different character tiles and overlays.

@Mshock777

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2014

Well, I'm better get to work then :-)
Also, what to do with those snow tiles?

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2014

Overlays are so little work, that you want to do seasonal stuff right away? :D

Just ignore it for now, is my suggestion. I would do seasonal tiles for you, but I just can't make winter terrain, I tried and it looks ugly.

@Mshock777

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2014

No, it looks good, just add a bit of color transition.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2014

Yeah, the baseline winter terrain in that PR's screencap was great.

@KA101 KA101 self-assigned this Sep 26, 2014

@KA101 KA101 merged commit 582f925 into CleverRaven:master Sep 26, 2014

@Robik81 Robik81 deleted the Robik81:OverlaysGenderSplit branch Oct 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.