Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds historical reenactor profession. #9366
Conversation
kevingranade
added
the
(S2 - Confirmed)
label
Oct 2, 2014
This comment has been minimized.
This comment has been minimized.
|
I suppose it's a reasonable use of gender-differentiated gear. Can't say I'm thrilled about it, though. |
This comment has been minimized.
This comment has been minimized.
|
Weapons versus tools and supplies. I think it makes for an interesting choice. |
This comment has been minimized.
This comment has been minimized.
|
I'm gonna upgrade undershirts to waistcoats for the soldiers, inasmuch as most period gear I've seen has visible waistcoat/vest types under the main one. (Granted, that's probably officer/dress gear, but still.) That and a minor cross-check and this is good to go. |
KA101
merged commit e49a09f
into
CleverRaven:master
Oct 2, 2014
1 check passed
default
This has been rescheduled for testing as the 'master' branch has been updated.
kevingranade
removed
the
(S2 - Confirmed)
label
Oct 2, 2014
Rivet-the-Zombie
deleted the
Rivet-the-Zombie:reenactor
branch
Oct 7, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Rivet-the-Zombie commentedOct 2, 2014
As suggested on the forums.