Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRetroDays tileset update (14-10-14) #9542
Conversation
KA101
reviewed
Oct 14, 2014
| "fg":1099, | ||
| "rotates":false | ||
| }, | ||
| { | ||
| "id":"smoxygen_tank", | ||
| "id":"oxygen", |
This comment has been minimized.
This comment has been minimized.
KA101
Oct 14, 2014
Contributor
There's still a "smoxygen_tank" in the JSON, tools.json at 337. Doesn't appear to be an "oxygen" item.
(When in doubt, ids don't change. Changed/deleted ids are the number one cause of nones.)
Update: Never mind, I'm blind and missed your moving it. :-/
This comment has been minimized.
This comment has been minimized.
|
I can't remember where I got it from exactly - it would have popped up in the tileset editor or missing tile checker - but there is an oxygen item on the item browser, at least. Not sure what's going on there. But yeah; I don't think I've ever removed entries from the tileset, even when it does seem like they've been changed or removed from the game. For example mon_zombie_fast changing to mon_zombie_dog a while back, and some things like rubble (seemingly?) changing from terrain to furniture objects sometime recently, with an accompanying change to the prefix in their ids. I just add the new one and leave the old one... just in case. |
This comment has been minimized.
This comment has been minimized.
|
OK, was gonna pull it but Git pitched a fit thanks to the parens in your branch name. Gonna ask you to copy this to a branch that doesn't include parentheses in its name. Sorry. |
This comment has been minimized.
This comment has been minimized.
|
Alright... git is sort of seat-of-the-pants stuff for me though. Do I need to make a new PR? |
This comment has been minimized.
This comment has been minimized.
|
Yeah you will. Basic process is going to be:
|
This comment has been minimized.
This comment has been minimized.
|
Thanks - new PR is up. Hopefully I got it right. |
Antistar commentedOct 14, 2014
Updated RetroDays10px and RetroDays20px tilesets.
Thread is here.
Let me know if I messed something up here; I've only made one PR before and that was a few months ago now.