Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Pontoon Bridge (CR) #9698

Merged
merged 12 commits into from Oct 27, 2014

Conversation

Projects
None yet
2 participants
@jokermatt999
Copy link
Contributor

commented Oct 27, 2014

Set up a basic pontoon bridge terrain and construction. Will create a separate PR for updating the existing bridge tiles, as they will need additional code.

"symbol": "8",
"color": "brown",
"move_cost": 4,
"flags": ["TRANSPARENT", "FLAT"]

This comment has been minimized.

Copy link
@KA101

KA101 Oct 27, 2014

Contributor

OK. Now if the pontoon bridge is destroyed or deconstructed, it should revert to the water.

@KA101

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2014

I like what I'm seeing here. You're gonna need one for shallow water too, though, and most rivers are over 50 tiles wide (24 game tiles per map-screen tile) so bridging 'em is gonna take some effort on the player's part.

But this looks Nifty.

jokermatt999 added some commits Oct 27, 2014

Maybe add a separate pontoon_dp
Rather than forgetting to copy it and just changing it to pontoon_sh
Tweaked shallow recipe
1 drum, since they're a pain enough anyway.
"deconstruct": {
"ter_set": "t_water_sh",
"items": [
{ "item": "2x4", "amount": 8 },

This comment has been minimized.

Copy link
@KA101

KA101 Oct 27, 2014

Contributor

Let 'em have the rope back, too. The drum is debatable.

"type" : "construction",
"description" : "Set up pontoon bridge over shallow water", "//": "Set up pontoon bridge",
"category" : "CONSTRUCT",
"difficulty" : 6,

This comment has been minimized.

Copy link
@KA101

KA101 Oct 27, 2014

Contributor

Diff 5 maybe, less to secure with the rope and lets players work up to it a little (make a dock, etc).

@jokermatt999

This comment has been minimized.

Copy link
Contributor Author

commented Oct 27, 2014

Went ahead and tweaked it a bit. Lowered the difficulty of both, returned ropes, and changed pontoon bridge over shallow water into a dock. It makes more sense that way anyway, and should make basic bridging a tad less tedious.

"symbol": "8",
"color": "brown",
"move_cost": 4,
"flags": ["TRANSPARENT", "FLAT"]

This comment has been minimized.

Copy link
@KA101

KA101 Oct 27, 2014

Contributor

Watch those commas. At this point I think I'll make the fixes in the merge.

This comment has been minimized.

Copy link
@jokermatt999

jokermatt999 Oct 27, 2014

Author Contributor

Thanks, it's a bit late for me and I really should stop typing at this
point. I really appreciate all the feedback and help!
On Oct 26, 2014 10:02 PM, "KA101" notifications@github.com wrote:

In data/json/terrain.json:

@@ -4531,5 +4531,55 @@
{ "item": "steel_chunk", "amount": 6, "minamount": 4}
]
}

  • },{
  •    "type" : "terrain",
    
  •    "id" : "t_dock",
    
  •    "name": "dock",
    
  •    "symbol": "8",
    
  •    "color": "brown",
    
  •    "move_cost": 4,
    
  •    "flags": ["TRANSPARENT", "FLAT"]
    

Watch those commas. At this point I think I'll make the fixes in the merge.


Reply to this email directly or view it on GitHub
https://github.com/CleverRaven/Cataclysm-DDA/pull/9698/files#r19386406.

@KA101 KA101 self-assigned this Oct 27, 2014

@KA101 KA101 merged commit 972508e into CleverRaven:master Oct 27, 2014

1 check failed

default
Details
@KA101

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2014

Had some more JSON issues but no major problems.

Welcome to the open source community, jokermatt999.

@jokermatt999 jokermatt999 deleted the jokermatt999:bridge branch Nov 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.