Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upContinuous recipe learning #9868
Conversation
This comment has been minimized.
This comment has been minimized.
|
Yeah! |
This comment has been minimized.
This comment has been minimized.
|
I've been wanting this. Thanks! |
This comment has been minimized.
This comment has been minimized.
|
Folks who complain about having recipes they don't use can use . to stop reading. So yeah. |
KA101
self-assigned this
Nov 7, 2014
This comment has been minimized.
This comment has been minimized.
|
Nice! |
KA101
merged commit e47310f
into
CleverRaven:master
Nov 7, 2014
Coolthulhu
deleted the
cataclysmbnteam:book-learn-recipe
branch
Nov 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Coolthulhu commentedNov 6, 2014
This PR changes the behavior of learning recipes from books that no longer grant skills.
This allows reading continuously, until all recipes available for current skill levels are learned.
Similarly to how normal book reading currently works, answering 'n' to "do you want to learn from book?" reads the book once, maybe teaching a single recipe.
Copypaste from skillbook reading allows rooters to root while reading recipes.
Normal skillbook and funbook reading is unaffected by the changes, they'll only be visible when reading books that no longer grant skills.
I also nailed a tiny bug that no one would ever notice - reading a useless (possibly fun) skillbook would ask for confirmation twice.