Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous recipe learning #9868

Merged
merged 1 commit into from Nov 7, 2014

Conversation

Projects
None yet
5 participants
@Coolthulhu
Copy link
Contributor

commented Nov 6, 2014

This PR changes the behavior of learning recipes from books that no longer grant skills.

This allows reading continuously, until all recipes available for current skill levels are learned.
Similarly to how normal book reading currently works, answering 'n' to "do you want to learn from book?" reads the book once, maybe teaching a single recipe.
Copypaste from skillbook reading allows rooters to root while reading recipes.

Normal skillbook and funbook reading is unaffected by the changes, they'll only be visible when reading books that no longer grant skills.

I also nailed a tiny bug that no one would ever notice - reading a useless (possibly fun) skillbook would ask for confirmation twice.

@Snaaty

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2014

Yeah!

@boydkr

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2014

I've been wanting this. Thanks!

@KA101

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2014

Folks who complain about having recipes they don't use can use . to stop reading. So yeah.

@KA101 KA101 self-assigned this Nov 7, 2014

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Nov 7, 2014

Nice!

@KA101 KA101 merged commit e47310f into CleverRaven:master Nov 7, 2014

@Coolthulhu Coolthulhu deleted the cataclysmbnteam:book-learn-recipe branch Nov 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.