Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded makeshift shotgun rounds and FMJ bullet pulling recipes #9957
Conversation
Zaweri
added some commits
Nov 10, 2014
KA101
reviewed
Nov 10, 2014
| "name" : "copper", | ||
| "symbol" : "=", | ||
| "color" : "yellow", | ||
| "description" : "Copper scraps. Pretty much useless now, except for makeshift shotgun rounds.", |
This comment has been minimized.
This comment has been minimized.
KA101
Nov 10, 2014
Contributor
I suspect folks could think of several things to do with the copper scraps.
This comment has been minimized.
This comment has been minimized.
Zaweri
Nov 10, 2014
Author
Contributor
Yeah, I'll let them come up with it themselves. I am too tired to work on anything right now.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Careful about that PRing from master branch! |
This comment has been minimized.
This comment has been minimized.
|
Eh, I made this fork just to pull request this, it is fine. |
This comment has been minimized.
This comment has been minimized.
|
But I might add a recipe to make copper ingots and copper tubing, and maybe a recipe for copper wire. |
John-Candlebury
reviewed
Nov 10, 2014
| "name" : "makeshift shotgun beanbag", | ||
| "symbol" : "=", | ||
| "color" : "red", | ||
| "description" : "A makeshift shotgun round intended to incapacitate the foe at minimal damage.", |
This comment has been minimized.
This comment has been minimized.
John-Candlebury
Nov 10, 2014
Contributor
I think its best to write "a foe" or "foes" rather than "the foe"
John-Candlebury
reviewed
Nov 10, 2014
| "symbol" : "=", | ||
| "color" : "red", | ||
| "description" : "A shotgun shell filled with whatever was lying around. They are more damaging than birdshot, but more inaccurate than most other types.", | ||
| "material" : "plastic", |
This comment has been minimized.
This comment has been minimized.
John-Candlebury
Nov 10, 2014
Contributor
While there may not be any glaring grammatical mistakes in this description, I don't actually like how this part sounds "but more inaccurate than most other types" why not change it to " They are more damaging than birdshot, but relatively inaccurate"
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This PR will return soon, I will just do some stuff fast |
Zaweri commentedNov 10, 2014
So, I put together this fix as a weekend project. Hope you guys like it!