Fix score calculation for Cold/Hot Run tabs in case of <1ms execution times #687
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
force-pushed
the
fix_zero_ratio
branch
from
f79668d to
541c9c5
Compare
Member
|
@puzpuzpuz Thanks for this fix. |
Member
|
Works now. 
|
Contributor
Author
|
@rschu1ze thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero exec times (or <1ms to be more precise) are silently replaced with
Infinityleading to broken score calculation. In particular, this breaks total ratio calculation asrelativeQueryTimechokes when it meets anInfinity(theaccumulatorvalue becomes-Infinity).The bug may be seen via this filter: https://benchmark.clickhouse.com/#system=+DcD|QtD&type=-&machine=+ae-l|g-l&cluster_size=-&opensource=-&tuned=+n&metric=hot&queries=-