Add support for extended precision integers and decimals #13097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nVector & ColumnDecimal for big ints
|
There were several attempts to fix unbundled build in this PR. The reason of fail is hack for There was a pef degradation in UUID hashes. Improved by perf optimization. There're some other strange perf degradations - not related to this patch. |
traceon
added a commit
to traceon/ClickHouse
that referenced
this pull request
Aug 20, 2020
* master: (43 commits) Publish list of tests that failed the concurrent fast test fix test Use gnu++2a instead of c++2a for unbundled build to fix numeric_limits<__int128> fix test Update 01453_fixsed_string_sort.sql Added test. Fix ColumnString::updatePermutationWithCollation. Add support for extended precision integers and decimals (ClickHouse#13097) remove retries Check that ya.make files are auto-generated Fix "Arcadia" ISSUES-4006 trigger CI again fixed typo arrayCompact Stratify nans comparison in arrayCompact function Remove even more useless code Remove useless code around zkutil Fix 00956_sensitive_data_masking flackiness Update docker/test/stress/run.sh add exclusive DDLGuard for database Fix handling embedded config. ...
yuzhichang
reviewed
Jan 26, 2021
| static constexpr bool is_POD = !is_big_int_v<T>; | ||
| using Container = std::conditional_t<is_POD, | ||
| PaddedPODArray<ValueType>, | ||
| std::vector<ValueType>>; |
There was a problem hiding this comment.
ColumnArray::sizeAt(n) may pass -1. It's safe for PaddedPODArray since it always allocate some unused bytes at the begin and end of the array. However it's dangerous for std::vector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add types
Int128,Int256,UInt256and related functions for them. Extend Decimals with Decimal256 (precision up to 76 digits). New types are under the settingallow_experimental_bigint_types.Detailed description / Documentation draft:
Int128realized over __int128 gcc/clang extention type.UInt128is not implemented. We need some goodunsigned __int128implementation that would be OK forUInt128andUUID.Continuation of #10388