Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out bigger inline threshold in clang release #15577

Closed
wants to merge 6 commits into from
Closed

Try out bigger inline threshold in clang release #15577

wants to merge 6 commits into from

Conversation

@danlark1
Copy link
Contributor

@danlark1 danlark1 commented Oct 3, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Try out clang inline threshold 1000

Detailed description / Documentation draft:
Let's try out inline threshold 1000 to see the binary size, compilation times and performance gains. Also it might show some places where inlining is crucial and we can manually write force inlines.

@danlark1 danlark1 changed the title Try out inline threshold in clang release Try out bigger inline threshold in clang release Oct 3, 2020
@danlark1
Copy link
Contributor Author

@danlark1 danlark1 commented Oct 4, 2020

Nothing interesting, let's try out experimental-new-pass-manager

@danlark1
Copy link
Contributor Author

@danlark1 danlark1 commented Oct 4, 2020

ThinLTO: 0.5%
ThinLTO + fexperimental-new-pass-manager: 1%, 2 min compile time reduction + 50mb smaller binary
ThinLTO + fexperimental-new-pass-manager + inline-threshold=1000: 4%, 7 min compile time increase + 450mb bigger binary
ThinLTO + fexperimental-new-pass-manager + inline-threshold=500: 2%, 3 min compile time increase + 170mb bigger binary

@alexey-milovidov
Copy link
Member

@alexey-milovidov alexey-milovidov commented Oct 5, 2020

4% will pay for 7 minutes and +450 MB binary size :)

@alexey-milovidov
Copy link
Member

@alexey-milovidov alexey-milovidov commented Oct 5, 2020

PS. I cannot understand the reason for MSan error :(

@danlark1
Copy link
Contributor Author

@danlark1 danlark1 commented Oct 5, 2020

PS. I cannot understand the reason for MSan error :(

100% unrelated flap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants