New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cluster type check during ON CLUSTER alter #16075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
Pull request with some product improvements
label
Oct 16, 2020
alesapin
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Oct 16, 2020
tavplubix
approved these changes
Oct 16, 2020
Functional stateless tests - 01133_max_result_rows - flacky |
This was referenced Oct 16, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 16, 2020
alesapin
added a commit
that referenced
this pull request
Oct 19, 2020
Backport #16075 to 20.10: Remove cluster type check during ON CLUSTER alter
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 19, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 19, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 19, 2020
alesapin
added a commit
that referenced
this pull request
Oct 20, 2020
Backport #16075 to 20.7: Remove cluster type check during ON CLUSTER alter
alesapin
added a commit
that referenced
this pull request
Oct 20, 2020
Backport #16075 to 20.8: Remove cluster type check during ON CLUSTER alter
alesapin
added a commit
that referenced
this pull request
Oct 20, 2020
Backport #16075 to 20.9: Remove cluster type check during ON CLUSTER alter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-improvement
Pull request with some product improvements
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now it's allowed to execute
ALTER ... ON CLUSTER
queries regardless of the<internal_replication>
setting in cluster config.// cc @Alex-Burmak