Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cluster type check during ON CLUSTER alter #16075

Merged
merged 1 commit into from Oct 16, 2020
Merged

Conversation

alesapin
Copy link
Member

@alesapin alesapin commented Oct 16, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now it's allowed to execute ALTER ... ON CLUSTER queries regardless of the <internal_replication> setting in cluster config.

// cc @Alex-Burmak

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Oct 16, 2020
@alesapin alesapin added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 16, 2020
@tavplubix tavplubix self-assigned this Oct 16, 2020
@tavplubix
Copy link
Member

Functional stateless tests - 01133_max_result_rows - flacky
Stress test (thread) - Sanitizer assert - fixed in #15984

@tavplubix tavplubix merged commit 1773124 into master Oct 16, 2020
@tavplubix tavplubix deleted the allow_alter_ddl branch October 16, 2020 18:20
alesapin added a commit that referenced this pull request Oct 19, 2020
Backport #16075 to 20.10: Remove cluster type check during ON CLUSTER alter
alesapin added a commit that referenced this pull request Oct 20, 2020
Backport #16075 to 20.7: Remove cluster type check during ON CLUSTER alter
alesapin added a commit that referenced this pull request Oct 20, 2020
Backport #16075 to 20.8: Remove cluster type check during ON CLUSTER alter
alesapin added a commit that referenced this pull request Oct 20, 2020
Backport #16075 to 20.9: Remove cluster type check during ON CLUSTER alter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants