Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mark cache settings initialization. #1636

Merged
merged 1 commit into from Dec 13, 2017

Conversation

@bocharov
Copy link
Contributor

@bocharov bocharov commented Dec 13, 2017

Before this change setting mark_cache_min_lifetime wasn't applied from the user settings, but only from the default.
There reason was that corresponding Settings initialization was after creation of the MarkCache.
This fix moves Settings initialization above creation of the MarkCache.

Before this change setting mark_cache_min_lifetime wasn't applied from the user settings, but only from the default.
There reason was that corresponding Settings initialization was after creation of the MarkCache.
This fix moves Settings initialization above creation of the MarkCache.
@alexey-milovidov alexey-milovidov merged commit 1612aab into ClickHouse:master Dec 13, 2017
@bobrik
Copy link
Contributor

@bobrik bobrik commented Dec 13, 2017

Having mark_cache_min_lifetime as an argument Context::setMarkCache would make this bug impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.