Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddlworker max entry metric #17464

Merged
merged 2 commits into from Dec 13, 2020
Merged

Conversation

amosbird
Copy link
Collaborator

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Export current max ddl entry executed by DDLWorker. It's useful to check if DDLWorker hangs somewhere.

Detailed description / Documentation draft:

None.

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Nov 27, 2020
@alexey-milovidov alexey-milovidov self-assigned this Nov 27, 2020
@alexey-milovidov
Copy link
Member

There is no test, but it's not necessarily for just one metric.

@amosbird
Copy link
Collaborator Author

There is no test, but it's not necessarily for just one metric.

Tests should be added)

@amosbird
Copy link
Collaborator Author

@alesapin ... why would these simple on cluster statements time out?

@alexey-milovidov
Copy link
Member

alexey-milovidov commented Nov 28, 2020

AFAIK Distributed DDLs only work when every server has its own hostname.

@amosbird
Copy link
Collaborator Author

AFAIK Distributed DDLs only work when every server has its own hostname.

But it works when I run fasttest docker image locally. It also works when running the test with hosted clickhouse.

@alexey-milovidov
Copy link
Member

Anyway, you can exclude it from the fast test.

@amosbird
Copy link
Collaborator Author

Test failure seems unrelated.

@alexey-milovidov alexey-milovidov merged commit 8702809 into ClickHouse:master Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants