Improve Normalization of ASTSelectWithUnionQuery #21246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
ucasfl
force-pushed
the
union-distinct-improve
branch
from
4e988d4
to
4c30c10
Compare
KochetovNicolai
approved these changes
Feb 26, 2021
Merged
|
I think this pr should be backport, it fixed some union related problems. @KochetovNicolai @alexey-milovidov |
filimonov
added
the
pr-must-backport
robot-clickhouse
added
pr-bugfix
This was referenced Mar 3, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 3, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 3, 2021
KochetovNicolai
added a commit
that referenced
this pull request
Mar 4, 2021
Backport #21246 to 21.1: Improve Normalization of ASTSelectWithUnionQuery
KochetovNicolai
added a commit
that referenced
this pull request
Mar 4, 2021
Backport #21246 to 21.2: Improve Normalization of ASTSelectWithUnionQuery
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 4, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix crash in
EXPLAINfor query withUNION. Fixes #20876, #21170Move
NormalizeSelectWithUnionQueryfromInterpreterSelectWithUnionQuerytoexecuteQuery.This should close #20876, close #21170, and should fulfill #21003, #21027 at the same time(these two prs can be closed).