Fix logical error in functions greatest/least #29454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
approved these changes
Sep 27, 2021
Avogar
force-pushed
the
fix-least-greatest
branch
from
b90df3b
to
cc40e36
Compare
|
Pavel Kruglov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
kitaisreal
approved these changes
Sep 28, 2021
This was referenced Sep 28, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 28, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 28, 2021
kitaisreal
added a commit
that referenced
this pull request
Sep 30, 2021
Backport #29454 to 21.10: Fix logical error in functions greatest/least
kitaisreal
added a commit
that referenced
this pull request
Sep 30, 2021
Backport #29454 to 21.9: Fix logical error in functions greatest/least
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix Logical error
Cannot capture columnsin functions greatest/least. Closes #29334Detailed description / Documentation draft:
...