Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better check for kafka_num_consumers #35926

Merged
merged 2 commits into from Apr 4, 2022
Merged

Better check for kafka_num_consumers #35926

merged 2 commits into from Apr 4, 2022

Conversation

alesapin
Copy link
Member

@alesapin alesapin commented Apr 4, 2022

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now kafka_num_consumers can be bigger than amount of physical cores in case of low resource machine (less than 16 cores).

@robot-ch-test-poll robot-ch-test-poll added the pr-improvement Pull request with some product improvements label Apr 4, 2022
Copy link
Contributor

@filimonov filimonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alesapin
Copy link
Member Author

alesapin commented Apr 4, 2022

Failure unrelated (some timeout with original ZooKeeper).

@alesapin alesapin merged commit 69fceb7 into master Apr 4, 2022
@alesapin alesapin deleted the better_consumers branch April 4, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants