Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show names of erroneous files in case of parsing errors while executing table functions #36314

Merged
merged 4 commits into from Apr 22, 2022

Conversation

CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented Apr 16, 2022

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Show names of erroneous files in case of parsing errors while executing table functions file, s3 and url.

Resolves #34198.

@CurtizJ CurtizJ marked this pull request as draft April 16, 2022 00:11
@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Apr 16, 2022
@kssenii kssenii self-assigned this Apr 18, 2022
Copy link
Member

@kssenii kssenii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -25,7 +26,7 @@ namespace DB
/**
* Perform S3 HTTP GET request and provide response to read.
*/
class ReadBufferFromS3 : public SeekableReadBufferWithSize
class ReadBufferFromS3 : public SeekableReadBufferWithSize, public WithFileName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also ReadBufferFromHDFS ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and maybe AzureBlobStorage.

@CurtizJ CurtizJ marked this pull request as ready for review April 19, 2022 15:57
@kssenii
Copy link
Member

kssenii commented Apr 22, 2022

Integration tests (release, actions) [1/2] — fail: 105

docker issue

Stateless tests flaky check (address, actions) — fail: 75, passed: 125

failed because the same test was run in parallel to itself (creates files with the same name as test name), possible only in flaky check.

@kssenii kssenii merged commit 33bb481 into ClickHouse:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file table function should print the name of erroneous file in case of error
3 participants