Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove group.id from StorageKafka::createWriteBuffer #37228

Merged
merged 1 commit into from
May 18, 2022
Merged

Remove group.id from StorageKafka::createWriteBuffer #37228

merged 1 commit into from
May 18, 2022

Conversation

mrk-andreev
Copy link
Contributor

@mrk-andreev mrk-andreev commented May 15, 2022 •
edited by rschu1ze
Loading

Changelog category

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Kafka does not need group.id on producer stage. In console log you can find Warning that describe this issue:

2022.05.15 17:59:13.270227 [ 137 ] {} <Warning> StorageKafka (topic-name): [rdk:CONFWARN] [thrd:app]: Configuration property group.id is a consumer property and will be ignored by this producer instance

@rschu1ze rschu1ze self-assigned this May 16, 2022
@rschu1ze rschu1ze added the can be tested Allows running workflows for external contributors label May 16, 2022
@rschu1ze rschu1ze merged commit 6b2a72d into ClickHouse:master May 18, 2022
@mrk-andreev mrk-andreev deleted the fix-rm-groupid-from-producer branch December 4, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rschu1ze rschu1ze

Labels
can be tested Allows running workflows for external contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrk-andreev @rschu1ze