Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Missing columns" for GLOBAL JOIN with CTE w/o alias #38056

Merged
merged 1 commit into from Jun 23, 2022

Conversation

azat
Copy link
Collaborator

@azat azat commented Jun 14, 2022

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix "Missing columns" for GLOBAL JOIN with CTE w/o alias

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-bugfix Pull request with bugfix, not backported by default label Jun 14, 2022
@azat
Copy link
Collaborator Author

azat commented Jun 18, 2022

Integration tests (release, actions) [2/2] — fail: 1, passed: 992, flaky: 1

  • test_jbod_balancer/test.py::test_replicated_balanced_merge_fetch
>       assert set(partitions) == set(["0", "1"])
E       AssertionError: assert {'1'} == {'1', '0'}
E         Extra items in the right set:
E         '0'
E         Full diff:
E         - {'1', '0'}
E         + {'1'}

Flaky - play.clickhouse.com

Stateless tests (thread, actions) [1/3] — Tests are not finished, fail: 8, passed: 1210, skipped: 6

Flakiness under TSan, need to take a closer look

Stress test (undefined, actions) — Killed by signal (in clickhouse-server.log)

insert into mt values
/var/log/clickhouse-server/clickhouse-server.err.log:2022.06.14 18:37:11.679032 [ 55321 ] {cace5396-da10-41d1-9953-c8412d40a161} <Fatal> : Logical error: 'Block structure mismatch in  function connect between CopyingDataToViewsTransform and PushingToWindowViewSink stream: different number of columns:

Backward compatiblity

2022.06.14 19:38:01.765914 [ 1135910 ] {} <Error> MutateFromLogEntryTask: virtual bool DB::ReplicatedMergeMutateTaskBase::executeStep(): Code: 36. DB::Exception: Unknown index: idx. (BAD_ARGUMENTS), Stack trace (when copying this message, always include the lines below):

@azat
Copy link
Collaborator Author

azat commented Jun 21, 2022

Can someone take a look please?

@antonio2368 antonio2368 self-assigned this Jun 23, 2022
Copy link
Member

@antonio2368 antonio2368 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonio2368 antonio2368 merged commit b2776e3 into ClickHouse:master Jun 23, 2022
@azat azat deleted the global-join-cte-fix branch June 23, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants