Fix DISTINCT with LIMIT in distributed queries
#38371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
CurtizJ
force-pushed
the
fix-distint-with-limit
branch
from
670781a
to
a215806
Compare
KochetovNicolai
approved these changes
Jun 24, 2022
|
@nickitat I think it would be better to move pre-distinct and pre-limit optimizations to query-plan level. Limit should probably already work fine. |
|
Why don't do it here in the way proposed by @KochetovNicolai ? |
|
It is better to have a small independent bugfix. It is backportable. |
|
Stateless tests (release, DatabaseReplicated, actions): tests failed to start. |
|
Backport? |
CurtizJ
added
the
pr-must-backport
This was referenced Jul 1, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 1, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 1, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 1, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 1, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 1, 2022
CurtizJ
added a commit
that referenced
this pull request
Jul 3, 2022
Backport #38371 to 22.5: Fix `DISTINCT` with `LIMIT` in distributed queries
CurtizJ
added a commit
that referenced
this pull request
Jul 3, 2022
Backport #38371 to 22.6: Fix `DISTINCT` with `LIMIT` in distributed queries
CurtizJ
added a commit
that referenced
this pull request
Jul 3, 2022
Backport #38371 to 22.4: Fix `DISTINCT` with `LIMIT` in distributed queries
CurtizJ
added a commit
that referenced
this pull request
Jul 3, 2022
Backport #38371 to 22.3: Fix `DISTINCT` with `LIMIT` in distributed queries
CurtizJ
added a commit
that referenced
this pull request
Jul 4, 2022
Backport #38371 to 21.8: Fix `DISTINCT` with `LIMIT` in distributed queries
Felixoid
added
the
pr-backports-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix incorrect result of distributed queries with
DISTINCTandLIMIT. Fixes #38282.